PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001055PacketFenceweb adminpublic2010-09-01 11:262011-01-26 15:38
Reporterrafamiga 
Assigned Toobilodeau 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.9.0 
Target Version1.9.1Fixed in Version1.9.1 
fixed in git revision
fixed in mtn revisiond1d5b327064018d52f33a7030f69be8f2576c41b
Summary0001055: deleting a node breaks paging
DescriptionWhen a node is deleted, the paging buttons disappear and plain message "(25 results)" with no navigation buttons is displayed under the node listing.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-09-01 11:26rafamigaNew Issue
2010-09-08 13:56obilodeauNote Added: 0001640
2010-09-08 13:56obilodeauReproducibilityalways => have not tried
2010-09-08 13:56obilodeauTarget Version => 1.9.1
2010-09-17 10:40obilodeauNote Added: 0001674
2010-09-17 10:40obilodeauAssigned To => obilodeau
2010-09-17 10:40obilodeauReproducibilityhave not tried => always
2010-09-17 10:40obilodeauStatusnew => assigned
2010-09-17 11:01obilodeauNote Added: 0001675
2010-09-17 13:22obilodeaumtn revision => d1d5b327064018d52f33a7030f69be8f2576c41b
2010-09-17 13:22obilodeauNote Added: 0001676
2010-09-17 13:22obilodeauStatusassigned => resolved
2010-09-17 13:22obilodeauFixed in Version => 1.9.1
2010-09-17 13:22obilodeauResolutionopen => fixed
2011-01-26 15:38obilodeauStatusresolved => closed

Notes
(0001640)
obilodeau   
2010-09-08 13:56   
I'll try to reproduce it in the lab. Targeted for 1.9.1
(0001674)
obilodeau   
2010-09-17 10:40   
reproductible
(0001675)
obilodeau   
2010-09-17 11:01   
header.php takes care of deletion. in there you can find:

    if($_REQUEST['action'] == 'edit' || $_REQUEST['action'] == 'delete'){
      $my_table->refresh(); 
    }


Commenting out the refresh() prevented the issue.

action edit is unaffected by the issue so I'm not sure if ->refresh() does something bad or if it's the fact that the whole page is reloaded and that delete could badly setup the filters or something like that.
(0001676)
obilodeau   
2010-09-17 13:22   
fixed it the cleanest way I could..

There's now a mechanism to tell the Table object that you require a special command to count number of rows in the table (allowing custom queries to be with set_count_cmd). Ported the node/view.php to this new functionality and updated Table->refresh() so that if there's a custom count query, then it needs to be updated.

fixed in 1.9 branch