PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001149PacketFencedhcppublic2011-01-10 15:172011-01-26 15:44
Reporterobilodeau 
Assigned Toobilodeau 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version2.0.1Fixed in Version2.0.1 
fixed in git revision
fixed in mtn revisionb022f8397dfee411d74b1bdad5f7d45f633ebbb3
Summary0001149: pfdhcplistener not properly updating iplog when configured with ip-helpers aka pfdhcplistener should update iplog on DHCP INFORM
DescriptionWe realized that pfdhcplistener only updates iplog on server replies. In an ip-helper address based setup, such replies will never reach the packetfence server since they are unicast packets going back to the ip-helper enabled switch.

Updating internal iplog database on DHCP INFORM packets will fix the problem.

It's an important enough problem that for those not ready to upgrade, a simple patch will be provided here that should apply cleanly to 1.8.x, 1.9.x.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch pfdhcplistener-ip-helper-support-fix.patch (3,706) 2011-01-13 10:58
https://www.packetfence.org/bugs/file_download.php?file_id=62&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-01-10 15:17obilodeauNew Issue
2011-01-10 15:17obilodeauStatusnew => assigned
2011-01-10 15:17obilodeauAssigned To => obilodeau
2011-01-10 16:59obilodeaumtn revision => 9982bf14855b4eb09ebe509e2e683f6f40ccbae1
2011-01-10 16:59obilodeauNote Added: 0001800
2011-01-10 16:59obilodeauStatusassigned => resolved
2011-01-10 16:59obilodeauFixed in Version => 2.0.1
2011-01-10 16:59obilodeauResolutionopen => fixed
2011-01-10 17:00obilodeauFile Added: pfdhcplistener-updates-iplog-on-inform.patch
2011-01-10 17:01obilodeauNote Added: 0001801
2011-01-12 12:35obilodeauNote Added: 0001805
2011-01-12 12:35obilodeauStatusresolved => feedback
2011-01-12 12:35obilodeauResolutionfixed => reopened
2011-01-12 15:03obilodeauNote Added: 0001806
2011-01-12 15:26obilodeauFile Added: pfdhcplistener-updates-iplog-on-inform-v2.patch
2011-01-12 15:26obilodeauFile Deleted: pfdhcplistener-updates-iplog-on-inform.patch
2011-01-12 15:28obilodeaumtn revision9982bf14855b4eb09ebe509e2e683f6f40ccbae1 => b022f8397dfee411d74b1bdad5f7d45f633ebbb3
2011-01-12 15:28obilodeauNote Added: 0001807
2011-01-12 15:28obilodeauStatusfeedback => resolved
2011-01-12 15:28obilodeauResolutionreopened => fixed
2011-01-13 10:57obilodeauFile Deleted: pfdhcplistener-updates-iplog-on-inform-v2.patch
2011-01-13 10:58obilodeauFile Added: pfdhcplistener-ip-helper-support-fix.patch
2011-01-13 11:10obilodeauNote Added: 0001808
2011-01-26 15:44obilodeauStatusresolved => closed

Notes
(0001800)
obilodeau   
2011-01-10 16:59   
pfdhcplistener now updates iplog when processing DHCP INFORM packets
(0001801)
obilodeau   
2011-01-10 17:01   
Attached patch should apply cleanly to most packetfence installations.

Apply from /usr/local/pf with:
patch -p1 < pfdhcplistener-updates-iplog-on-inform.patch
(0001805)
obilodeau   
2011-01-12 12:35   
apparently some devices don't send DHCP INFORM at the end of their DHCP handshake so we need to find another way
(0001806)
obilodeau   
2011-01-12 15:03   
After reading RFC 2131, we should use DHCP REQUEST instead of DHCP INFORM as our source of updated client IP information.
(0001807)
obilodeau   
2011-01-12 15:28   
Fixed for good.

Updated attached patch that should apply cleanly on 1.9.x, 2.0.0 and maybe 1.8.x.
(0001808)
obilodeau   
2011-01-13 11:10   
Updated patch.