PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001291PacketFencecorepublic2011-10-03 10:442011-12-30 23:38
Reporterobilodeau 
Assigned Tofgaudreault 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.1.0Fixed in Version3.1.0 
fixed in git revision
fixed in mtn revision84fa24bdd352259ecb4d3425934b366cfcafb62a
Summary0001291: normalize_time doesn't handle months
DescriptionSince normalize_time is now used for guest access duration, people start asking to get a month field for expiration..

Because of the conflict between m - minutes and m - months, I think that we should modify normalize_time so that the short identifiers should be the same as strftime's.

This would be a change that needs our users to upgrade their config properly so not in a bugfix cycle.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-10-03 10:44obilodeauNew Issue
2011-10-31 10:47fgaudreaultNote Added: 0002407
2011-12-08 16:32fgaudreaultmtn revision => 6dffac13ba82c9dbe1043f5fceb3c42437130cbc
2011-12-08 16:32fgaudreaultStatusnew => resolved
2011-12-08 16:32fgaudreaultFixed in Version => +1
2011-12-08 16:32fgaudreaultResolutionopen => fixed
2011-12-08 16:32fgaudreaultAssigned To => fgaudreault
2011-12-09 09:34obilodeauNote Added: 0002469
2011-12-09 09:34obilodeauStatusresolved => feedback
2011-12-09 09:34obilodeauResolutionfixed => reopened
2011-12-09 11:08fgaudreaultmtn revision6dffac13ba82c9dbe1043f5fceb3c42437130cbc => 84fa24bdd352259ecb4d3425934b366cfcafb62a
2011-12-09 11:08fgaudreaultNote Added: 0002470
2011-12-09 11:08fgaudreaultStatusfeedback => resolved
2011-12-09 11:08fgaudreaultResolutionreopened => fixed
2011-12-21 13:58obilodeauNote Added: 0002476
2011-12-30 23:29obilodeauFixed in Version+1 => 3.1.0
2011-12-30 23:37obilodeauNote Added: 0002497
2011-12-30 23:37obilodeauStatusresolved => closed
2011-12-30 23:38obilodeauTarget Version+2 => 3.1.0

Notes
(0002407)
fgaudreault   
2011-10-31 10:47   
Using UNIX "date" format:
S - second
M - minutes
H - hours
d - day
m - month
Y - year
W - Weeks

Using ISO 8601 :
s - second
m - minutes
h - hours
D - Days
W - Weeks (not in standard)
M - Months
Y - Years

I like the second one.
(0002469)
obilodeau   
2011-12-09 09:34   
some additional changes required
pf.conf.defaults carries a lot of values that aren't there after the patch.

doing a regexp search searching for digit then d reveals them (in vim press / then \dd <enter>)
there's also one with w

also a FAQ entry pasting the above format (telling it's from ISO8601) wouldn't hurt

Lastly I wouldn't have committed that to 3_0 but trunk but then again our next release will most likely be out of trunk anyway so don't bother.
(0002470)
fgaudreault   
2011-12-09 11:08   
Changed the pf.conf.defaults with the proper time values.

The FAQ will follow.
(0002476)
obilodeau   
2011-12-21 13:58   
Additional changes made today were required for the Web Admin to catch up with the change.
(0002497)
obilodeau   
2011-12-30 23:37   
Released in version 3.1.0.