PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001369PacketFencehardware modulespublic2012-01-24 15:132012-02-28 14:31
Reporterobilodeau 
Assigned Toobilodeau 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.2.0Fixed in Version3.2.0 
fixed in git revision
fixed in mtn revision2e87f3f6e97f08b4b463975c9ece984fbd949a4f
Summary0001369: thread crash with floating network devices with VoIP through SSH transport
DescriptionNet::Appliance::Session doesn't seem thread-safe. 

Jan 24 14:37:55 pfsetvlan(7) ERROR: Error connecting to ... using SSH. Error: Input/output error (pf::SNMP::Cisco::Catalyst_2950::setPortSecurityMaxSecureMacAddrVlanAccessByIfIndex)

thread failed to start: Must connect before you can begin_privileged (0000001)
    (W threads)(S) The entry point function of threads->create() failed for some reason.


trying a small PoC of forking the call in a separate process
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch floating-network-devices-thread-crash-cisco-with-ssh-fix1369.patch (4,914) 2012-01-27 15:21
https://www.packetfence.org/bugs/file_download.php?file_id=135&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-01-24 15:13obilodeauNew Issue
2012-01-24 15:13obilodeauStatusnew => assigned
2012-01-24 15:13obilodeauAssigned To => obilodeau
2012-01-25 15:19obilodeauNote Added: 0002552
2012-01-27 15:21obilodeauFile Added: floating-network-devices-thread-crash-cisco-with-ssh-fix1369.patch
2012-01-27 15:55obilodeaumtn revision => 2e87f3f6e97f08b4b463975c9ece984fbd949a4f
2012-01-27 15:55obilodeauNote Added: 0002554
2012-01-27 15:55obilodeauStatusassigned => resolved
2012-01-27 15:55obilodeauFixed in Version => trunk
2012-01-27 15:55obilodeauResolutionopen => fixed
2012-02-28 14:22obilodeauTarget Version+1 => 3.2.0
2012-02-28 14:22obilodeauFixed in Versiontrunk => 3.2.0
2012-02-28 14:31obilodeauNote Added: 0002585
2012-02-28 14:31obilodeauStatusresolved => closed

Notes
(0002552)
obilodeau   
2012-01-25 15:19   
PoC confirmed to work: I'll re-route the call from pfsetvlan to spawn a pfcmd_vlan process which will instantiate a switch object and perform the work.
(0002554)
obilodeau   
2012-01-27 15:55   
using pfcmd_vlan's new -runSwitchMethod feature used to fix this issue by calling the _<method> in a new process.
(0002585)
obilodeau   
2012-02-28 14:31   
Fixed in recently released 3.2.0.