PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001523PacketFencepublic2012-08-21 11:552012-09-06 10:57
Reporterobilodeau 
Assigned Toobilodeau 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.5.1Fixed in Version3.5.1 
fixed in git revision7d8a39599
fixed in mtn revision
Summary0001523: person pid parsing regression
DescriptionWhen triggered by the Web admin with the form:

ARGS='person add user@email.com firstname="",lastname="",email="",telephone="",company="",address="",notes="",sponsor=""' /usr/local/pf/bin/pfcmd

Exposed to the person tab in 3.4.0. Regex issue actually introduced in 3.0.0 when the manage_register was migrated from value to pid.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
has duplicate 0001528closed  Command "pfcmd person add" ignores space. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-21 11:55obilodeauNew Issue
2012-08-21 11:58obilodeauStatusnew => assigned
2012-08-21 11:58obilodeauAssigned To => obilodeau
2012-08-21 16:48obilodeauNote Added: 0002955
2012-08-22 09:53obilodeaugit revision => 7d8a39599
2012-08-22 09:53obilodeauNote Added: 0002956
2012-08-22 09:53obilodeauStatusassigned => resolved
2012-08-22 09:53obilodeauFixed in Version => +1
2012-08-22 09:53obilodeauResolutionopen => fixed
2012-08-23 10:53francisRelationship addedhas duplicate 0001528
2012-09-06 10:56obilodeauTarget Version => 3.5.1
2012-09-06 10:56obilodeauFixed in Version+1 => 3.5.1
2012-09-06 10:57obilodeauNote Added: 0003022
2012-09-06 10:57obilodeauStatusresolved => closed

Notes
(0002955)
obilodeau   
2012-08-21 16:48   
I just finished writing the regression test. Will commit tomorrow.
(0002956)
obilodeau   
2012-08-22 09:53   
Explanation: The pid parser allowed spaces even in the unquoted format which means that it greadily expanded to grab the next token (pid firstname=...) instead of just sticking to it's pid.

fix in pull request: https://github.com/inverse-inc/packetfence/pull/52 [^]

targeted for next stable release
(0003022)
obilodeau   
2012-09-06 10:57   
fix released in 3.5.1 yesterday