Anonymous | Login | 2024-08-24 20:22 EDT | ![]() |
Main | My View | View Issues | Change Log | Roadmap |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | Project | Category | View Status | Date Submitted | Last Update | |||
0001352 | PacketFence | configuration | public | 2011-12-27 09:27 | 2012-02-28 14:31 | |||
Reporter | fgaudreault | |||||||
Assigned To | obilodeau | |||||||
Priority | high | Severity | minor | Reproducibility | always | |||
Status | closed | Resolution | fixed | |||||
Platform | OS | OS Version | ||||||
Product Version | devel | |||||||
Target Version | 3.2.0 | Fixed in Version | 3.2.0 | |||||
Summary | 0001352: Misleading error message if missing management type | |||||||
Description | Instead of saying that there is a typo or that the management type is missing from pf.conf, we have this misleading error message : Can't call method "tag" on an undefined value at /usr/local/pf/lib/pf/pfcmd/checkup.pm line 169 (0000001) (F) You used the syntax of a method call, but the slot filled by the object reference or package name contains an undefined value. Something like this will reproduce the error: $BADREF = undef; process $BADREF 1,2,3; $BADREF->process(1,2,3); Uncaught exception from user code: Can't call method "tag" on an undefined value at /usr/local/pf/lib/pf/pfcmd/checkup.pm line 169. at /usr/local/pf/lib/pf/pfcmd/checkup.pm line 169 pf::pfcmd::checkup::interfaces() called at /usr/local/pf/lib/pf/pfcmd/checkup.pm line 87 pf::pfcmd::checkup::sanity_check('httpd', 'snmptrapd', 'pfsetvlan', 'pfdhcplistener', 'pfmon') called at /usr/local/pf/bin/pfcmd line 1357 main::checkup('httpd', 'snmptrapd', 'pfsetvlan', 'pfdhcplistener', 'pfmon') called at /usr/local/pf/bin/pfcmd line 1280 main::service() called at /usr/local/pf/bin/pfcmd line 201 main::__ANON__() called at /usr/local/pf/bin/pfcmd line 218 | |||||||
Additional Information | To Fix : - Ensure that you have an interface in pf.conf with type=management | |||||||
Tags | No tags attached. | |||||||
fixed in git revision | ||||||||
fixed in mtn revision | a074717c2d137b2d447d818975f852b0e1730caa | |||||||
Attached Files | ||||||||
![]() |
|
(0002494) obilodeau (reporter) 2011-12-30 11:55 |
Easy to fix: wrap in try {} catch {}; or do an explicit ref($...) eq 'objectType' and add warning or fatal. |
(0002563) obilodeau (reporter) 2012-01-31 15:03 |
was already fixed in rev dd48c0b1f6074b4079419f8f56496c515a238e93 but the fix was quite primitive and only focused on the mgmt interface not defined use-case and not every caller who requires a Net::Netmask object. This new fix wraps the entire config processing in a try {} catch {} and so should catch other types of mis-use. Also, everything requiring a Net::Netmask object also got a new check and exception thrown. |
(0002592) obilodeau (reporter) 2012-02-28 14:31 |
Fixed in recently released 3.2.0. |
![]() |
|||
Date Modified | Username | Field | Change |
2011-12-27 09:27 | fgaudreault | New Issue | |
2011-12-30 11:55 | obilodeau | Note Added: 0002494 | |
2012-01-31 15:03 | obilodeau | mtn revision | => a074717c2d137b2d447d818975f852b0e1730caa |
2012-01-31 15:03 | obilodeau | Note Added: 0002563 | |
2012-01-31 15:03 | obilodeau | Status | new => resolved |
2012-01-31 15:03 | obilodeau | Fixed in Version | => trunk |
2012-01-31 15:03 | obilodeau | Resolution | open => fixed |
2012-01-31 15:03 | obilodeau | Assigned To | => obilodeau |
2012-02-28 14:22 | obilodeau | Target Version | => 3.2.0 |
2012-02-28 14:22 | obilodeau | Fixed in Version | trunk => 3.2.0 |
2012-02-28 14:31 | obilodeau | Note Added: 0002592 | |
2012-02-28 14:31 | obilodeau | Status | resolved => closed |
Copyright © 2000 - 2012 MantisBT Group |