0001031: better validation for networks.conf file - PacketFence

PacketFence - BTS - PacketFence

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0001031

PacketFence

error-handling

public

2010-07-13 15:02

2011-09-21 22:16

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

minor

Reproducibility

sometimes

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

1.8.7

Target Version

Fixed in Version

3.0.0

fixed in git revision

fixed in mtn revision

Summary

0001031: better validation for networks.conf file

Description

Prevent stack traces like the following by adding a simple test for pf_gateway's presence.

> config files|start
> Use of uninitialized value in concatenation (.) or string at
> /usr/local/pf/lib/pf/services.pm line 386 (0000001)
> (W uninitialized) An undefined value was used as if it were already
> defined. It was interpreted as a "" or a 0, but maybe it was a mistake.
> To suppress this warning assign a defined value to your variables.
>
> To help you figure out what was undefined, perl tells you what operation
> you used the undefined value in. Note, however, that perl optimizes your
> program and the operation displayed in the warning may not necessarily
> appear literally in your program. For example, "that $foo" is
> usually optimized into "that " . $foo, and the warning will refer to
> the concatenation (.) operator, even though there is no . in your
> program.

Steps To Reproduce

Additional Information