PacketFence - BTS - PacketFence
View Issue Details
0001057PacketFenceerror-handlingpublic2010-09-01 22:222011-01-26 15:38
obilodeau 
obilodeau 
normalminoralways
closedfixed 
 
1.9.11.9.1 
9ee660314f3bc62134e78b5ef57baf2746fadf52
0001057: registration.maxnodes is not enforced the same way on the captive portal and in pfcmd manage register
registration.maxnodes is not enforced the same way on the captive portal and in pfcmd manage register. This leads to a strange situation like the captive portal accepted you but when trying to register you generate an error in the log and you stay in registration VLAN.

Sep 01 21:49:27 register.cgi(0) DEBUG: got (1, 0) from authenticate() call (pf::web::web_user_authenticate)

Sep 01 21:49:27 register.cgi(0) INFO: calling /usr/local/pf/bin/pfcmd 'manage register 00:21:86:9e:ab:f8 
"douche" pid="1",user_agent="Mozilla 5.0  X11; U; Linux i686; en-US; rv:1.9.0.8  
Gecko 2009033100 Ubuntu 9.04  jaunty  Firefox 3.0.8",vlan="66"' (pf::web::web_node_register)

Sep 01 21:49:28 pfcmd(0) ERROR: maxnodes met or exceeded - registration of 00:21:86:9e:ab:f8 to douche 
failed (pf::node::node_register)
Sep 01 21:49:28 pfcmd(0) INFO: VLAN isolation is enabled and manage_register is part of adjustswitchportvlanreasons 
(main::generate_switchport_vlan_assignment)
Sep 01 21:49:28 pfcmd(0) INFO: 00:21:86:9e:ab:f8 is currentlog connected at 10.42.0.101 ifIndex 10018 
in VLAN 65 (main::generate_switchport_vlan_assignment)


changing in node_register():
   -my $owned_nodes = pf::person::person_nodes($pid);
   +my $owned_nodes = node_pid($pid);
No tags attached.
Issue History
2010-09-01 22:22obilodeauNew Issue
2010-09-01 22:22obilodeauStatusnew => assigned
2010-09-01 22:22obilodeauAssigned To => obilodeau
2010-09-21 16:42obilodeaumtn revision => 9ee660314f3bc62134e78b5ef57baf2746fadf52
2010-09-21 16:42obilodeauNote Added: 0001685
2010-09-21 16:42obilodeauStatusassigned => resolved
2010-09-21 16:42obilodeauFixed in Version => 1.9.1
2010-09-21 16:42obilodeauResolutionopen => fixed
2011-01-26 15:38obilodeauStatusresolved => closed

Notes
(0001685)
obilodeau   
2010-09-21 16:42   
After some discussions, we agreed that maxnodes is really there to enforce a maximum number of 'registered' nodes on a pid.

So we fixed the node_register call to use the proper mechanism to enforce that coherently.

Fix in 1.9 branch.