PacketFence - BTS - PacketFence
View Issue Details
0001157PacketFencepublic2011-01-18 15:422011-01-26 15:44
obilodeau 
obilodeau 
normalminorrandom
closedfixed 
2.0.0 
2.0.12.0.1 
32140b9d364221adfed25780343917fedcefa3f1
0001157: dot11Deauthentication traps causing warnings and potentially crashing threads
Since the refactoring of pfsetvlan, hard-coded trapIfIndex = 'WIFI' for dot11Deauth traps disappeared from the code.

trapIfIndex is then assigned to switch_port. Then it creates a problem because the thread-safe shared data structure is relying on the presence of switch_port throughout pfsetvlan. When it's trying to print it and it's undef bang! When it's calling SQL (traplog_insert) bang!..

Severity is minor because such traps should be disabled by default.

Fix this and remember
- Remaining hard-coded trapIfIndex = 'WIFI' calls should be removed. HP and Extricom are guilty.
No tags attached.
Issue History
2011-01-18 15:42obilodeauNew Issue
2011-01-18 15:50obilodeauStatusnew => assigned
2011-01-18 15:50obilodeauAssigned To => obilodeau
2011-01-18 16:15obilodeaumtn revision => 32140b9d364221adfed25780343917fedcefa3f1
2011-01-18 16:15obilodeauNote Added: 0001820
2011-01-18 16:15obilodeauStatusassigned => resolved
2011-01-18 16:15obilodeauFixed in Version => 2.0.1
2011-01-18 16:15obilodeauResolutionopen => fixed
2011-01-26 15:44obilodeauStatusresolved => closed

Notes
(0001820)
obilodeau   
2011-01-18 16:15   
Setting switch_port to temporary 'WIFI' value for dot11Deauthentication traps in pfsetvlan's parseTrap. This solves warnings and potential crashers when receiving dot11Deauthentication traps (which should not be the default case).

Also removed pf::SNMP::... references to trapIfIndex = 'WIFI' and re-enabled HP's Controllers parseTrap.