PacketFence - BTS - PacketFence | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0001165 | PacketFence | captive portal | public | 2011-01-27 14:32 | 2011-03-03 15:25 |
| Reporter | obilodeau | ||||
| Assigned To | obilodeau | ||||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Platform | OS | OS Version | |||
| Product Version | |||||
| Target Version | Fixed in Version | 2.1.0 | |||
| fixed in git revision | |||||
| fixed in mtn revision | 4c8394517644f19282368334711622c079d7ec57 | ||||
| Summary | 0001165: failing perlcritic tests in pf::web | ||||
| Description | the hook we use in pf::web use eval in a way that makes perlcritic go angry:
if ( -r "$conf_dir/templates/status.pl" ) {
my $include_fh;
open $include_fh, '<', "$conf_dir/templates/status.pl";
while (<$include_fh>) {
eval $_;
}
close $include_fh;
}
Since the creation of the pf::web::custom extension point, we don't really need this feature anymore and it has always quite hackish anyway. | ||||
| Steps To Reproduce | |||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2011-01-27 14:32 | obilodeau | New Issue | |||
| 2011-01-27 14:32 | obilodeau | Status | new => assigned | ||
| 2011-01-27 14:32 | obilodeau | Assigned To | => obilodeau | ||
| 2011-01-27 15:35 | obilodeau | mtn revision | => 4c8394517644f19282368334711622c079d7ec57 | ||
| 2011-01-27 15:35 | obilodeau | Note Added: 0001841 | |||
| 2011-01-27 15:35 | obilodeau | Status | assigned => resolved | ||
| 2011-01-27 15:35 | obilodeau | Fixed in Version | => 2.0.2 | ||
| 2011-01-27 15:35 | obilodeau | Resolution | open => fixed | ||
| 2011-03-03 15:20 | obilodeau | Fixed in Version | 2.0.2 => 2.1.0 | ||
| 2011-03-03 15:25 | obilodeau | Status | resolved => closed | ||
| Notes | |||||
|
|
|||||
|
|
||||