PacketFence - BTS - PacketFence
View Issue Details
0001322PacketFencecorepublic2011-11-01 10:282011-12-30 23:44
bonald 
obilodeau 
normalminoralways
closedfixed 
3.0.2 
3.1.0 
8caa27e9c6243bc7cd90159207e8ba9461d16271
0001322: Slash in PID

Invalid argument supplied for foreach() in /usr/local/pf/html/admin/person/lookup.php on line 39
Error: Problems executing 'PFCMD person view host/comp1.local'

Command not understood. (pfcmd grammar test failed at line 230.)
No tags attached.
Issue History
2011-11-01 10:28bonaldNew Issue
2011-11-01 10:51bonaldNote Added: 0002414
2011-11-02 10:37obilodeauNote Added: 0002422
2011-11-02 15:13obilodeauNote Added: 0002423
2011-11-03 11:02obilodeauStatusnew => assigned
2011-11-03 11:02obilodeauAssigned To => obilodeau
2011-11-03 12:27obilodeaumtn revision => 8caa27e9c6243bc7cd90159207e8ba9461d16271
2011-11-03 12:27obilodeauNote Added: 0002424
2011-11-03 12:27obilodeauStatusassigned => resolved
2011-11-03 12:27obilodeauFixed in Version => trunk
2011-11-03 12:27obilodeauResolutionopen => fixed
2011-12-30 23:28obilodeauFixed in Versiontrunk => 3.1.0
2011-12-30 23:40obilodeauNote Added: 0002506
2011-12-30 23:44obilodeauStatusresolved => closed

Notes
(0002414)
bonald   
2011-11-01 10:51   
not the best way but this will remove the error
$user_name =~ s/\//./g;

Add this to radius.pm line 219

It will replace / with .
(0002422)
obilodeau   
2011-11-02 10:37   
A radius-based work-around is also possible:
- use a realm that would strip the User-Name properly (/etc/raddb/modules/realm)
- override _parseRequest in lib/pf/radius/custom.pm to use Stripped-User-Name instead of User-Name

The advantage of the above work-around is that you will not loose it on upgrades. It's using stable extension points.

Deciding what's a proper pid (characters allowed) is the scope for a larger design problem we intend to solve down the road.
(0002423)
obilodeau   
2011-11-02 15:13   
Ok, we looked into it today and we decided that we are going to fix this. Hang on, it'll be fixed eventually. Meanwhile keep your s///g workaround.
(0002424)
obilodeau   
2011-11-03 12:27   
Fixed in trunk will be released in our next 'major' version which should be soon anyways.
(0002506)
obilodeau   
2011-12-30 23:40   
Released in version 3.1.0.