PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001405PacketFencecorepublic2012-03-26 12:102012-04-23 11:01
Reporterdwuelfrath 
Assigned Toobilodeau 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiondevel 
Target Version3.3.2Fixed in Version3.3.2 
fixed in git revision251e6a839f5b36db3c1e8919d5a07674ed3d1195
fixed in mtn revision
Summary0001405: pfsetvlan trap_limit feature problematic behavior
DescriptionEven if no action is configured in [vlan.trap_limit_action], when [vlan.trap_limit_threshold] is reached for any switch (even 127.0.0.1) the trap processing is aborted.
Steps To Reproduce
Additional Information # skip traps coming from switch ifIndex that reached traps limit threshold
            if ( defined($trapHashRef->{'trapIfIndex'})
                    && isenabled($Config{'vlan'}{'trap_limit'})
                    && check_traps_limit_threshold($switch, $trapHashRef->{'trapIfIndex'}) ) {
                $logger->warn("We received too many traps (over $Config{'vlan'}{'trap_limit_threshold'}) in a minute) "
                        . "from ifIndex $trapHashRef->{'trapIfIndex'} of switch $switch->{_ip}");
            # skip unknown traps
            } elsif ( $trapType ne 'unknown' ) {
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-26 12:10dwuelfrathNew Issue
2012-03-26 12:13dwuelfrathNote Added: 0002624
2012-04-18 11:19obilodeauTarget Versiontrunk => +1
2012-04-20 14:47obilodeaugit revision => 251e6a839f5b36db3c1e8919d5a07674ed3d1195
2012-04-20 14:47obilodeauNote Added: 0002676
2012-04-20 14:47obilodeauStatusnew => resolved
2012-04-20 14:47obilodeauFixed in Version => +1
2012-04-20 14:47obilodeauResolutionopen => fixed
2012-04-20 14:47obilodeauAssigned To => obilodeau
2012-04-23 11:00obilodeauTarget Version+1 => 3.3.2
2012-04-23 11:00obilodeauFixed in Version+1 => 3.3.2
2012-04-23 11:01obilodeauNote Added: 0002684
2012-04-23 11:01obilodeauStatusresolved => closed

Notes
(0002624)
dwuelfrath   
2012-03-26 12:13   
When the first if statement is true, workflow skips the elsif.

Should detach the if statement from the rest of the process but without interfering with the trap_limit workflow.

Should also make sure to not act on local traps.
(0002676)
obilodeau   
2012-04-20 14:47   
Fix developed in branch: fix/1405-trap-limit-behavior, merged in stable.
(0002684)
obilodeau   
2012-04-23 11:01   
fix released in 3.3.2