PacketFence - BTS - PacketFence
View Issue Details
0001410PacketFenceguestspublic2012-03-29 14:302015-02-13 15:42
obilodeau 
 
normalfeatureN/A
closedopen 
 
 
0001410: Guest pre-registration with SMS activation
During the guest pre-registration development[1], the potential pre-registered by SMS activation use case was dropped because it would have taken too much time to do than allocated with the current architecture.

Basically, the missing field pid in sms_activation prevented easy integration but re-adding that field to the schema is not necessarily the right thing to do.

SMS and email activation are very similar in nature (both generate codes, store future/current node information and send the code by email). The common code between the two modules is quite large and it shouldn't be that way (remember the DRY principle).

A clean way to implement pre-reg by SMS would be to re-architect the pf::email_activation <-> pf::sms_activation interactions by merging them together. Objects and a basic inheritance would do it:
pf::email_activation -> pf::user_activation::email, pf::user_activation::sponsor, pf::user_activation::sms

Food for thoughts once we decide to re-implement it.

[1] https://github.com/inverse-inc/packetfence/tree/feature%2Fsponsored-guests [^]
No tags attached.
Issue History
2012-03-29 14:30obilodeauNew Issue
2012-03-29 14:35obilodeauNote Added: 0002631
2015-02-13 15:42lmunroNote Added: 0003837
2015-02-13 15:42lmunroStatusnew => closed

Notes
(0002631)
obilodeau   
2012-03-29 14:35   
Bump if you feel this is important.
(0003837)
lmunro   
2015-02-13 15:42   
These bugs have been sitting untouched since 2012.
Closing them and possibly reopening in github tracker where relevant.