PacketFence - BTS - PacketFence | |||||
View Issue Details | |||||
ID | Project | Category | View Status | Date Submitted | Last Update |
0001410 | PacketFence | guests | public | 2012-03-29 14:30 | 2015-02-13 15:42 |
Reporter | obilodeau | ||||
Assigned To | |||||
Priority | normal | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | open | ||
Platform | OS | OS Version | |||
Product Version | |||||
Target Version | Fixed in Version | ||||
fixed in git revision | |||||
fixed in mtn revision | |||||
Summary | 0001410: Guest pre-registration with SMS activation | ||||
Description | During the guest pre-registration development[1], the potential pre-registered by SMS activation use case was dropped because it would have taken too much time to do than allocated with the current architecture. Basically, the missing field pid in sms_activation prevented easy integration but re-adding that field to the schema is not necessarily the right thing to do. SMS and email activation are very similar in nature (both generate codes, store future/current node information and send the code by email). The common code between the two modules is quite large and it shouldn't be that way (remember the DRY principle). A clean way to implement pre-reg by SMS would be to re-architect the pf::email_activation <-> pf::sms_activation interactions by merging them together. Objects and a basic inheritance would do it: pf::email_activation -> pf::user_activation::email, pf::user_activation::sponsor, pf::user_activation::sms Food for thoughts once we decide to re-implement it. [1] https://github.com/inverse-inc/packetfence/tree/feature%2Fsponsored-guests [^] | ||||
Steps To Reproduce | |||||
Additional Information | |||||
Tags | No tags attached. | ||||
Relationships | |||||
Attached Files | |||||
Issue History | |||||
Date Modified | Username | Field | Change | ||
2012-03-29 14:30 | obilodeau | New Issue | |||
2012-03-29 14:35 | obilodeau | Note Added: 0002631 | |||
2015-02-13 15:42 | lmunro | Note Added: 0003837 | |||
2015-02-13 15:42 | lmunro | Status | new => closed |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|