PacketFence - BTS - PacketFence
View Issue Details
0001447PacketFencerefactoringpublic2012-05-08 10:352012-08-07 09:46
obilodeau 
obilodeau 
normaltweakN/A
closedfixed 
 
3.5.03.5.0 
b69201b18f324842a22b28fa19b450df05bc3b86
0001447: get rid of pf.conf's interface.gateway
Prove that it is irrelevant first, then get rid of it (if possible).

Will make configurator, startup sanity check and several portions of the code quite simpler.
No tags attached.
Issue History
2012-05-08 10:35obilodeauNew Issue
2012-05-08 10:35obilodeauStatusnew => assigned
2012-05-08 10:35obilodeauAssigned To => obilodeau
2012-05-08 11:29obilodeauNote Added: 0002708
2012-05-08 11:32obilodeauNote Edited: 0002708
2012-05-08 11:37obilodeauNote Edited: 0002708
2012-07-31 14:37dwuelfrathgit revision => b69201b18f324842a22b28fa19b450df05bc3b86
2012-07-31 14:37dwuelfrathNote Added: 0002853
2012-07-31 14:37dwuelfrathStatusassigned => resolved
2012-07-31 14:37dwuelfrathResolutionopen => fixed
2012-07-31 14:37dwuelfrathFixed in Version => 3.5.0
2012-08-07 09:46obilodeauNote Added: 0002894
2012-08-07 09:46obilodeauStatusresolved => closed
2012-08-07 09:46obilodeauTarget Version+1 => 3.5.0

Notes
(0002708)
obilodeau   
2012-05-08 11:29   
(edited on: 2012-05-08 11:37)
caller stack

pf::config puts interface.gateway in $int_obj->tag( "gw" ... )

This is consumed by:

ip2gateway (pf::util)
  pf::rawip
  - trapmac
  - freemac
    - bin/pfcmd manage freemac (and relevant grammar and/or lib/pf/pfcmd.pm)
  pf::web
  - generate_status_page (and relevant apache config)
  sbin/pfmon
  - listen_arp

get_gateways (pf::util)
  pf::services
  - generate_snort_config (tags{'gateways'} meant for config rewrite), flush from rules and config
  pf::util
  - preload_network_range
    - preload_trappable_ip and preload_reggable_ip
      - pfmon_preload (disabled by default but could be enabled)
  sbin/pfdhcplistener (ignore DHCP served from local gateway in rogue handling code)
  - inrange_ip (only internally used in pf::util)
    - trappable_ip
      - pf::web status page, rendered through captive-portal/register.cgi (delete it all!)
      - pf::violation's violation_trigger, remove it too, already covered by IDS config
      - pf::rawip's trapmac, already to be deleted by above
    - reggable_ip: no external caller, ready to be removed

removal:
- lib/pf/pfcmd/pfcmd.pm (grammar)
- checkup: gateway
- web?
- move pf::rawip into addons/ as arp code, remove dependency from debian/rpm and remove from tests


(0002853)
dwuelfrath   
2012-07-31 14:37   
Been merged in feature/catalyst-configurator a long ago but is now part of stable (3.5.0) since we include feature/catalyst-configurator in stable (3.5.0)
(0002894)
obilodeau   
2012-08-07 09:46   
fix released in 3.5.0