PacketFence - BTS - PacketFence
View Issue Details
0001474PacketFenceweb adminpublic2012-06-21 10:412012-09-06 10:57
fgaudreault 
fgaudreault 
lowfeatureN/A
closedfixed 
devel 
3.5.13.5.1 
fc8320925c43602e6614d341c574a533934d169c
0001474: Release Date should be added automatically when closing a violation if nothing is specified in the field
On the web admin, when closing a violation, it should automatically put now() as the release_date. Idem when the user close it from the portal.
No tags attached.
related to 0001475resolved fgaudreault Refactor the Bandwidth accounting violation process 
Issue History
2012-06-21 10:41fgaudreaultNew Issue
2012-06-21 10:46fgaudreaultRelationship addedrelated to 0001475
2012-06-22 17:50fgaudreaultNote Added: 0002820
2012-06-22 17:51fgaudreaultNote Edited: 0002820
2012-06-22 17:52fgaudreaultNote Edited: 0002820
2012-06-22 17:53fgaudreaultNote Edited: 0002820
2012-07-19 11:08fgaudreaultNote Added: 0002845
2012-08-03 17:10fgaudreaultgit revision => fc8320925c43602e6614d341c574a533934d169c
2012-08-03 17:10fgaudreaultNote Added: 0002869
2012-08-03 17:10fgaudreaultStatusnew => resolved
2012-08-03 17:10fgaudreaultResolutionopen => fixed
2012-08-03 17:10fgaudreaultAssigned To => fgaudreault
2012-08-03 17:10fgaudreaultFixed in Version => +1
2012-09-06 10:56obilodeauTarget Version => 3.5.1
2012-09-06 10:56obilodeauFixed in Version+1 => 3.5.1
2012-09-06 10:57obilodeauNote Added: 0003027
2012-09-06 10:57obilodeauStatusresolved => closed

Notes
(0002820)
fgaudreault   
2012-06-22 17:50   
(edited on: 2012-06-22 17:53)
Branched in feature/acct_violations

I went even further:
- Added a fast close/open button:
 * Closing using that button will put NOW as the release_date
 * Opening using that button will remove the release_date (and open the violation). We can see if we want to put the new release_date then (if we open a violation with a window).

- Added a "window" concept to the violations (just like unregdate)
 * You can define a period of time you want the violation to be active
 * Past that time, the violation will be closed by pfmon automatically
 * Supports the normalized format + "dynamic" keyword (see below). "0" is considered forever.

TO DO:
- Support the dynamic keyword (for accounting violations). The core will calculate the appropriate window.
 * Exemple: I have an accounting violation of 20G/month, I want to put the release date at the end of the month if you trigger the limit after say 3days.

(0002845)
fgaudreault   
2012-07-19 11:08   
Ready in acct_violations. Missing the doc updates tho.
(0002869)
fgaudreault   
2012-08-03 17:10   
All fixed in devel!
(0003027)
obilodeau   
2012-09-06 10:57   
fix released in 3.5.1 yesterday