PacketFence - BTS - PacketFence
View Issue Details
0001540PacketFencescanningpublic2012-09-06 08:582012-09-06 11:05
dwuelfrath 
dwuelfrath 
lowminoralways
acknowledgedopen 
 
 
0001540: pf::scan will try to instanciate unknown module
Even if we do a check if the scanning type exist or not, we do not handle the result and continue the workflow.
https://github.com/inverse-inc/packetfence/blob/stable/lib/pf/scan.pm#L93 [^]
No tags attached.
Issue History
2012-09-06 08:58dwuelfrathNew Issue
2012-09-06 08:59dwuelfrathAssigned To => dwuelfrath
2012-09-06 08:59dwuelfrathStatusnew => acknowledged
2012-09-06 08:59dwuelfrathTarget Version => +1
2012-09-06 11:01obilodeauNote Added: 0003028
2012-09-06 11:05obilodeauNote Added: 0003029
2012-09-06 11:05obilodeauPrioritynormal => low
2012-09-06 11:05obilodeauSeveritymajor => minor

Notes
(0003028)
obilodeau   
2012-09-06 11:01   
Another thing to look at: https://github.com/inverse-inc/packetfence/blob/stable/lib/pf/scan.pm#L165 [^]
(0003029)
obilodeau   
2012-09-06 11:05   
Ok, pf::scan's run_scan is never checked for success or not. Also scans are initiated explicitly by bin/pfcmd and never inside daemons so the crash wouldn't be as bad as causing a daemon to crash.

That said, it could introduce subtle mistake if we ever decide start scans inside daemons or long term processes like apache so it should be fixed.