PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000782PacketFencepublic2009-08-20 14:282011-01-26 15:43
Reporterobilodeau 
Assigned Toobilodeau 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
fixed in git revision
fixed in mtn revision
Summary0000782: redir.cgi crash: Use of uninitialized value in concatenation (.) or string
DescriptionMailing list user reported a problem:

Wed Aug 19 11:05:15 2009] [error] [client 149.xxx.xxx.xxx] [Wed Aug 19 11:05:15 2009] redir.cgi: Use of uninitialized value in concatenation (.) or string at /usr/local/pf/lib/pf/web.pm line 395.

I suggested changing line 395 of lib/pf/web.pm from:
$logger->warn("unknown User-Agent: $user_agent");
to
$logger->warn("unknown User-Agent: ".$user_agent);

and user reported that it fixed his problem.

I should merge that in mtn and evaluate if I mis-used $user_agent somewhere else. Problem most likely occurs when there are quotes or things like that in the $user_agent string.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-08-20 14:28obilodeauNew Issue
2009-08-20 14:28obilodeauStatusnew => assigned
2009-08-20 14:28obilodeauAssigned To => obilodeau
2009-10-15 15:36rbalzardNote Added: 0001339
2009-10-15 15:36rbalzardNote Added: 0001340
2009-10-15 15:36rbalzardStatusassigned => resolved
2009-10-15 15:36rbalzardResolutionopen => fixed
2011-01-26 15:43obilodeauStatusresolved => closed

Notes
(0001339)
rbalzard   
2009-10-15 15:36   
I changed $user_agent 2 twice again in web.pm and that was it.
(0001340)
rbalzard   
2009-10-15 15:36   
fixed in revision 88bcdd0146de8b604fa21d409103b59d3985f9a1