PacketFence - BTS - PacketFence
View Issue Details
0000848PacketFenceerror-handlingpublic2009-11-12 11:112012-09-06 10:57
obilodeau 
obilodeau 
highmajoralways
closedfixed 
 
3.5.13.5.1 
404be9f
0000848: password validation
Our grammar is very strict on certain characters you can use as arguments.

Often these non-approved characters are pushed in as passwords in the various places where we use them in packetfence (switch management, user management, etc.). No error is shown when this happens. pfcmd just silently fails (but this will be dealt with in bug 0000847)

Anyway we can be better at that.

We should validate password fields in the web admin using the same regexp as the grammar and show a nice error message saying invalid characters in password.
usability
Issue History
2009-11-12 11:11obilodeauNew Issue
2009-11-12 11:11obilodeauStatusnew => assigned
2009-11-12 11:11obilodeauAssigned To => obilodeau
2010-03-01 13:28obilodeauCategory1.8.5 => error-handling
2010-03-01 13:28obilodeauSummaryerror handling: password validation => password validation
2010-09-08 14:08obilodeauTarget Version => 1.9.1
2010-09-08 14:09obilodeauDescription Updated
2010-09-15 11:22obilodeauTarget Version1.9.1 => 1.9.2
2010-09-22 16:02obilodeauTarget Version1.9.2 => 1.9.3
2010-09-28 10:16obilodeauTag Attached: usability
2012-08-31 10:36obilodeauNote Added: 0003001
2012-08-31 14:11obilodeauNote Added: 0003005
2012-08-31 14:30obilodeauNote Added: 0003006
2012-08-31 14:32obilodeauTarget Version1.9.3 => +1
2012-09-05 11:32obilodeaugit revision => 404be9f
2012-09-05 11:32obilodeauNote Added: 0003011
2012-09-05 11:32obilodeauStatusassigned => resolved
2012-09-05 11:32obilodeauFixed in Version => +1
2012-09-05 11:32obilodeauResolutionopen => fixed
2012-09-06 10:56obilodeauTarget Version+1 => 3.5.1
2012-09-06 10:56obilodeauFixed in Version+1 => 3.5.1
2012-09-06 10:57obilodeauNote Added: 0003021
2012-09-06 10:57obilodeauStatusresolved => closed

Notes
(0003001)
obilodeau   
2012-08-31 10:36   
Especially problematic is the fact that we don't support $ as a valid character.
(0003005)
obilodeau   
2012-08-31 14:11   
Branch fix/848-password-validation was just pushed that fixes this.
(0003006)
obilodeau   
2012-08-31 14:30   
opened pull request: https://github.com/inverse-inc/packetfence/pull/56 [^]
(0003011)
obilodeau   
2012-09-05 11:32   
fix will be part of next stable release
(0003021)
obilodeau   
2012-09-06 10:57   
fix released in 3.5.1 yesterday