PacketFence - BTS - PacketFence |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0000856 | PacketFence | error-handling | public | 2009-11-18 13:23 | 2015-02-13 15:26 |
|
| Reporter | obilodeau | |
| Assigned To | obilodeau | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | open | |
| Platform | | OS | | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| fixed in git revision | |
| fixed in mtn revision | |
|
| Summary | 0000856: Cisco's getVlan with unknown ifIndex returns undef |
| Description | around line 367 in lib/pf/SNMP/Cisco.pm, added a TODO task
task in code at rev no: 17bc0fbf8af80db10c3bcb5af6dda2d404c4b35a
check parent bug for how to resolve |
| Steps To Reproduce | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | child of | 0000855 | closed | | SNMP subs error-handling/exceptions |
|
| Attached Files |  0000856_v1.patch (1,245) 2011-04-12 15:29
https://www.packetfence.org/bugs/file_download.php?file_id=90&type=bug
0000856_v2.patch (1,244) 2011-04-12 15:29
https://www.packetfence.org/bugs/file_download.php?file_id=91&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2009-11-18 13:23 | obilodeau | New Issue | |
| 2009-11-18 13:23 | obilodeau | Status | new => assigned |
| 2009-11-18 13:23 | obilodeau | Assigned To | => obilodeau |
| 2009-11-18 13:23 | obilodeau | Relationship added | child of 0000855 |
| 2010-04-15 17:43 | obilodeau | Project | PacketFence 1.9 => PacketFence |
| 2011-01-18 11:41 | obilodeau | Target Version | => 2.1.0 |
| 2011-03-03 15:15 | obilodeau | Target Version | 2.1.0 => +1 |
| 2011-03-03 15:18 | obilodeau | Target Version | +1 => +2 |
| 2011-04-12 15:29 | fgaudreault | File Added: 0000856_v1.patch | |
| 2011-04-12 15:29 | fgaudreault | File Added: 0000856_v2.patch | |
| 2011-04-12 15:30 | fgaudreault | Note Added: 0002027 | |
| 2011-04-12 15:30 | fgaudreault | Tag Attached: Code Review | |
| 2011-04-21 17:50 | obilodeau | Note Added: 0002037 | |
| 2011-04-21 17:51 | obilodeau | Tag Detached: Code Review | |
| 2011-04-21 17:51 | obilodeau | Note Edited: 0002037 | |
| 2015-02-13 15:26 | lmunro | Note Added: 0003729 | |
| 2015-02-13 15:26 | lmunro | Status | assigned => closed |
|
Notes |
|
|
(0002027)
|
|
fgaudreault
|
|
2011-04-12 15:30
|
|
Two patches possible, choose the one you prefer :
- V1: This will return $result only if the value exists
- V2: This will check if $result, log and return 0 if not existing. |
|
|
|
(0002037)
|
|
obilodeau
|
2011-04-21 17:50
(edited on: 2011-04-21 17:51) |
|
Here the problem is not to return a different value but to prevent callers from doing something stupid. All callers should be validated and proper error handling be put in place upstream.
Not ready for review since we don't know the impact of such a change at the moment.
|
|
|
|
(0003729)
|
|
lmunro
|
|
2015-02-13 15:26
|
|
Old issues.
Most are not relevant to PF 4 and up.
Let's reopen the ones that matter when we move to github. |
|