PacketFence - BTS - PacketFence
View Issue Details
0000936PacketFenceperformancepublic2010-03-19 11:582015-02-13 15:24
obilodeau 
obilodeau 
normalminoralways
closedopen 
 
 
0000936: get rid of use threads where it is not required
Right now, in pf::util we could get rid of them but there are other cases where a bit of moving around will be required. In example pf::vlan.

Everywhere we use threads and threads::shared only to set up:
Log::Log4perl::MDC->put( 'tid', threads->self->tid() );

We should do it at the very beginning of the thread's existence and push that out of modules. In the above vlan example, it should be done in pfsetvlan.

Aside from compile time performance in some spots (pfcmd for instance) another benefit would be that we might be able to use DProf (which currently crashes on our codebase when importing threads).
No tags attached.
Issue History
2010-03-19 11:58obilodeauNew Issue
2010-03-19 11:58obilodeauStatusnew => assigned
2010-03-19 11:58obilodeauAssigned To => obilodeau
2010-04-15 17:43obilodeauProjectPacketFence 1.9 => PacketFence
2010-05-04 14:41obilodeauTarget Version1.9.0 => 1.10.0
2010-09-28 17:45obilodeauNote Added: 0001699
2010-11-19 14:25obilodeauTarget Version1.10.0 => 2.0.0
2011-01-18 09:47obilodeauTarget Version2.0.0 => 2.1.0
2011-03-03 15:16obilodeauTarget Version2.1.0 => +1
2011-03-03 15:18obilodeauTarget Version+1 => +2
2015-02-13 15:24lmunroNote Added: 0003684
2015-02-13 15:24lmunroStatusassigned => closed

Notes
(0001699)
obilodeau   
2010-09-28 17:45   
this has been partially fixed lately with a removal in pf::vlan
(0003684)
lmunro   
2015-02-13 15:24   
These issues are too old to still be relevant.

Let's start anew.