PacketFence - BTS - PacketFence | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0000943 | PacketFence | refactoring | public | 2010-04-07 11:38 | 2015-02-13 15:26 |
| Reporter | obilodeau | ||||
| Assigned To | |||||
| Priority | high | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | open | ||
| Platform | OS | OS Version | |||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| fixed in git revision | |||||
| fixed in mtn revision | |||||
| Summary | 0000943: create interfaces (abstract classes) to our switch objects | ||||
| Description | at least the following interfaces should be created (with their implemented methods): - switch -- _setVlan -- getVersion - switch port-security -- authorizeMAC -- isPortSecurityEnabled -- getSecureMacAddresses -- getAllSecureMacAddresses - switch MAB -- NasPortToIfIndex - switch 802.1x -- NasPortToIfIndex -- dot1xPortReauthenticate - AP / controller -- deauthenticateMac The interface would implement the methods but die on them with: die ("unimplemented!") This would allow that in tests, we could test switches against each interface and trap for die and if a switch dies then it's improperly implementing it's type. I think this would need removal of empty implementations in pf::SNMP so this might be a hard decision to take. Check here for the design pattern: http://perldesignpatterns.com/?AbstractClass [^] I think something like: use base('pf::SNMP::Cisco', 'pf::SNMP::WiredDot1x', 'pf::SNMP::WiredMAB', 'pf::SNMP::PortSecurity') shoudl work and we should be careful about left to right since the search for sub implementations is done from left to right. | ||||
| Steps To Reproduce | |||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2010-04-07 11:38 | obilodeau | New Issue | |||
| 2010-04-07 11:38 | obilodeau | Status | new => assigned | ||
| 2010-04-07 11:38 | obilodeau | Assigned To | => obilodeau | ||
| 2010-04-07 11:47 | obilodeau | Note Added: 0001507 | |||
| 2010-04-15 17:43 | obilodeau | Project | PacketFence 1.9 => PacketFence | ||
| 2011-01-18 11:43 | obilodeau | Target Version | => trunk | ||
| 2011-10-05 09:32 | obilodeau | Note Added: 0002312 | |||
| 2012-10-19 14:21 | fgaudreault | Assigned To | obilodeau => | ||
| 2012-10-19 14:21 | fgaudreault | Target Version | devel => general | ||
| 2015-02-13 15:26 | lmunro | Note Added: 0003687 | |||
| 2015-02-13 15:26 | lmunro | Status | assigned => closed | ||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||