PacketFence - BTS - PacketFence
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000977PacketFencerefactoringpublic2010-05-04 16:492011-01-26 15:42
Reporterobilodeau 
Assigned Toobilodeau 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version2.0.0Fixed in Version2.0.0 
fixed in git revision
fixed in mtn revision8116f6f5657fa9232ce57c50c926e66f23abe079
Summary0000977: VLAN field in node table should be re-thought
DescriptionThe node view field is useful for admins to get a quick overview of what node is in what state and in what vlan.

Right now the vlan field in node table is not kept accurate by PacketFence beccause it was historically used for vlan assignation. Also, we generally recommend people needing per-node VLAN assignments to override vlan.pm and return $vlan (or more recently $node_info->{vlan}) to assign VLANs. Because of that we can't override the node.vlan field without causing adverse effects on current customers.

We should rename the vlan field there to target_vlan or something (check with Regis) and drop the vlan field. The node view should join on the locationlog table and show that information for VLAN info (which is kept accurate).
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0000914closed obilodeau node table should not carry data duplicated from locationlog 
related to 0001082closed  Specify a VLAN per node 
parent of 0000927closed obilodeau VLAN field in node view should be re-labeled 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2010-05-04 16:49obilodeauNew Issue
2010-05-04 16:49obilodeauStatusnew => assigned
2010-05-04 16:49obilodeauAssigned To => obilodeau
2010-05-04 16:49obilodeauRelationship addedparent of 0000927
2010-05-04 16:49obilodeauRelationship addedrelated to 0000914
2010-09-29 17:25obilodeauRelationship addedrelated to 0001082
2010-09-30 18:58obilodeaumtn revision => 8116f6f5657fa9232ce57c50c926e66f23abe079
2010-09-30 18:58obilodeauNote Added: 0001704
2010-09-30 18:58obilodeauStatusassigned => resolved
2010-09-30 18:58obilodeauFixed in Version => trunk
2010-09-30 18:58obilodeauResolutionopen => fixed
2010-11-19 14:25obilodeauTarget Version1.10.0 => 2.0.0
2010-12-15 11:37obilodeauFixed in Versiontrunk => 2.0.0
2011-01-26 15:42obilodeauStatusresolved => closed

Notes
(0001704)
obilodeau   
2010-09-30 18:58   
node.vlan is now node.bypass_vlan.

It is not enforced by default. You will need to override get_normal_vlan in pf::vlan::custom. See pf::vlan's get_normal_vlan for an example usage. Issue 0001082 will enable that behavior by default.

Fix in trunk. Database changes were required.