PacketFence - BTS - PacketFence
View Issue Details
0000984PacketFencepublic2010-05-07 10:472011-01-26 15:38
obilodeau 
obilodeau 
normalminoralways
closedfixed 
 
1.9.01.9.0 
bd68354d7f35fb252363d178ea087b706c3a92b9
0000984: multiple problems with reports
I found a missing "use pf::util;" in pf::pfcmd::report when messing out with dhcp fingerprints. To avoid future regressions, I built a simple test case that would call all the methods in pf::pfcmd::report and expect results and no warnings.

Running that test showed more problems. I don't know if they were introduced in the database rework, induced by the dataset or if they were already there.

report....1..19
ok 1 - use pf::pfcmd::report;
ok 2 - testing report_os_all call
ok 3 - testing report_os_active call
ok 4 - testing report_osclass_all call

not ok 5 - testing report_osclass_active call
# Failed test 'testing report_osclass_active call'
# in report.t at line 39.
ok 6 - testing report_active_all call
ok 7 - testing report_inactive_all call
ok 8 - testing report_unregistered_active call
ok 9 - testing report_unregistered_all call

not ok 10 - testing report_active_reg call
# Failed test 'testing report_active_reg call'
# in report.t at line 39.
ok 11 - testing report_registered_all call

not ok 12 - testing report_registered_active call
# Failed test 'testing report_registered_active call'
# in report.t at line 39.
ok 13 - testing report_openviolations_all call

# Failed test 'testing report_openviolations_active call'
# in report.t at line 39.
not ok 14 - testing report_openviolations_active call
ok 15 - testing report_statics_all call

not ok 16 - testing report_statics_active call
# Failed test 'testing report_statics_active call'
# in report.t at line 39.
ok 17 - testing report_unknownprints_all call

# Failed test 'testing report_unknownprints_active call'
not ok 18 - testing report_unknownprints_active call
# in report.t at line 39.
# Looks like you failed 6 tests of 19.
ok 19 - no warnings
dubious
        Test returned status 6 (wstat 1536, 0x600)
DIED. FAILED tests 5, 10, 12, 14, 16, 18
        Failed 6/19 tests, 68.42% okay
Failed Test Stat Wstat Total Fail Failed List of Failed
-------------------------------------------------------------------------------
report.t 6 1536 19 6 31.58% 5 10 12 14 16 18
Failed 1/1 test scripts, 0.00% okay. 6/19 subtests failed, 68.42% okay.

I'm fixing these.
No tags attached.
Issue History
2010-05-07 10:47obilodeauNew Issue
2010-05-07 10:47obilodeauStatusnew => assigned
2010-05-07 10:47obilodeauAssigned To => obilodeau
2010-05-07 11:36obilodeaumtn revision => bd68354d7f35fb252363d178ea087b706c3a92b9
2010-05-07 11:36obilodeauStatusassigned => resolved
2010-05-07 11:36obilodeauFixed in Version => 1.9.0
2010-05-07 11:36obilodeauResolutionopen => fixed
2011-01-26 15:38obilodeauStatusresolved => closed

There are no notes attached to this issue.