0001248: htpasswd uses md5 by default; login.php uses crypt - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001248

PacketFence

core

public

2011-08-18 07:49

2011-09-21 22:16

Reporter

psnizek

Assigned To

obilodeau

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.2.1

Target Version

Fixed in Version

3.0.0

Summary

0001248: htpasswd uses md5 by default; login.php uses crypt

Description

my system: modified slackware 13.1, vanilla-kept daemons, packetfence 2.2.1 from tarball.

If I run installer.pl the admin password is encrypted using md5 instead of crypt.
htpasswd's help (from httpd 2.2.19) says that md5 is the default. htpasswd's manpage states this for Windows but says crypt for *nix systems.
Nevertheless, md5 seems to be used as the default also on *nix.
Maybe precisely specifying the encryption algo by using htpasswd's -d switch in installer.pl could prevent issues. Please see the patch below.
I have not tested this on Redhat or Centos. It may work as expected there.

Additional Information

--- installer.pl.orig 2011-08-18 13:36:18.235323981 +0200
+++ installer.pl 2011-08-17 20:21:17.193888957 +0200
@@ -354,7 +354,7 @@
         $adminuser = <STDIN>;
         chop $adminuser;
         $adminuser = "admin" if ( !$adminuser );
- } while ( system("htpasswd -c $conf_dir/admin.conf $adminuser") );
+ } while ( system("htpasswd -d -c $conf_dir/admin.conf $adminuser") );
}

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

28f3574c29359a831dc48a3764db69f15d2d7abb

Attached Files

Relationships

Notes
(0002148) obilodeau (reporter) 2011-08-23 12:16	Thanks for the report. I added the -d switch in installer and also Admin -> Add User (where we call htpasswd). Fixed in trunk, which will be released soon as 3.0.

(0002244) obilodeau (reporter) 2011-09-21 22:15	fix released in 3.0

Issue History
Date Modified	Username	Field	Change
2011-08-18 07:49	psnizek	New Issue
2011-08-23 12:16	obilodeau	mtn revision	=> 28f3574c29359a831dc48a3764db69f15d2d7abb
2011-08-23 12:16	obilodeau	Note Added: 0002148
2011-08-23 12:16	obilodeau	Status	new => resolved
2011-08-23 12:16	obilodeau	Fixed in Version	=> trunk
2011-08-23 12:16	obilodeau	Resolution	open => fixed
2011-08-23 12:16	obilodeau	Assigned To	=> obilodeau
2011-09-21 22:07	obilodeau	Fixed in Version	trunk => 3.0.0
2011-09-21 22:15	obilodeau	Note Added: 0002244
2011-09-21 22:16	obilodeau	Status	resolved => closed