PacketFence
Bug Tracking System

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001250PacketFenceaddonspublic2011-08-23 11:212012-02-28 14:31
Reportermaikel 
Assigned Toobilodeau 
PrioritynormalSeveritytweakReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiondevel 
Target Version3.2.0Fixed in Version3.2.0 
Summary0001250: pfcmd_vlan getSwitch location
DescriptionSmall patch below

Allowing pfcmd_vlan to show the SNMP location string

Think its handy to get it in more mainstream pf. Probably needs to be moved in pfcmd since ifIndex is not really needed

/usr/local/pf/bin/pfcmd_vlan -getSwitchLocation -ifIndex 6 -switch 192.168.10.10

Amsterdam; Nice Road; Building; Room

With this, the Ip shown for the switch, can now also be parsed into a more human readable form

Additional Information20a21
> -getSwitchLocation show SNMP location of specified switch
126a128
> my $getSwitchLocation;
149a152
> "getSwitchLocation" => \$getSwitchLocation,
454a458
> || $getSwitchLocation
570a575,578
> } elsif ($getSwitchLocation) {
> $logger->debug("start handling 'getSwitchLocation' command");
> print $switch->getSwitchLocation($ifIndex) . "\n";
> $logger->debug("finished handling 'getSwitchLocation' command");




TagsNo tags attached.
fixed in git revision
fixed in mtn revisiona73a634c916156132177094c3213815e07e8ea09
Attached Filesdiff file icon pfcmd_vlan.diff [^] (1,940 bytes) 2012-01-11 10:13 [Show Content]

- Relationships

-  Notes
(0002524)
maikel (reporter)
2012-01-10 10:02

Is this still something packetfence is interested in? Its quite handy for me to have this pfcmd_vlan command because there is no custom.pm support for it. If not ;) no worries, patching is also fine
(0002530)
obilodeau (reporter)
2012-01-11 08:09

I'll look at it in this cycle. Thanks for bumping up.

Can you provide the patch in unified diff format (diff -u) and attach it instead of putting it in a comment section please?
(0002535)
maikel (reporter)
2012-01-11 10:13

I have added the diff
(0002556)
obilodeau (reporter)
2012-01-28 17:32

First, I just committed error handling and got rid of the ifIndex parameter from the pf::SNMP::getSwitchLocation.

it's in rev: 4a7da4c1d746427a50ef6e6874c88a527856dbb0
(0002557)
obilodeau (reporter)
2012-01-28 17:53

patch applied (with modification to remove $ifIndex's requirement) in rev: a73a634c916156132177094c3213815e07e8ea09

thanks for your contribution!
(0002593)
obilodeau (reporter)
2012-02-28 14:31

Fixed in recently released 3.2.0.

- Issue History
Date Modified Username Field Change
2011-08-23 11:21 maikel New Issue
2012-01-10 10:02 maikel Note Added: 0002524
2012-01-11 08:08 obilodeau Status new => assigned
2012-01-11 08:08 obilodeau Assigned To => obilodeau
2012-01-11 08:09 obilodeau Note Added: 0002530
2012-01-11 10:13 maikel File Added: pfcmd_vlan.diff
2012-01-11 10:13 maikel Note Added: 0002535
2012-01-28 17:32 obilodeau Note Added: 0002556
2012-01-28 17:53 obilodeau mtn revision => a73a634c916156132177094c3213815e07e8ea09
2012-01-28 17:53 obilodeau Note Added: 0002557
2012-01-28 17:53 obilodeau Status assigned => resolved
2012-01-28 17:53 obilodeau Fixed in Version => trunk
2012-01-28 17:53 obilodeau Resolution open => fixed
2012-02-28 14:22 obilodeau Target Version => 3.2.0
2012-02-28 14:22 obilodeau Fixed in Version trunk => 3.2.0
2012-02-28 14:31 obilodeau Note Added: 0002593
2012-02-28 14:31 obilodeau Status resolved => closed


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker