0001267: add template toolkit error reporting on all ->process calls - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001267

PacketFence

captive portal

public

2011-09-14 16:31

2014-06-02 08:15

Reporter

obilodeau

Assigned To

fdurand

Priority

high

Severity

trivial

Reproducibility

random

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0001267: add template toolkit error reporting on all ->process calls

Description

Just like I did here at revno: 49438888fdbade2110cb70324e34381245c1bf25

--- pf/lib/pf/web/guest.pm      0a9d7807c131a50376d474012b92a1a629d5e85c
+++ pf/lib/pf/web/guest.pm      44fa683d2c052e22eac0e0f12b25250469c5a1e3
@@ -228,7 +228,7 @@ sub generate_registration_page {
     #}

     my $template = Template->new({ INCLUDE_PATH => [$CAPTIVE_PORTAL{'TEMPLATE_DIR'}], });
-    $template->process($pf::web::guest::REGISTRATION_TEMPLATE, $vars);
+    $template->process($pf::web::guest::REGISTRATION_TEMPLATE, $vars) || $logger->error($template->error());
     
exit;
 }

It helped out identify a nasty bug. It should be done by default on all the $template->process() calls.

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Attached Files

Relationships

Notes
(0002696) obilodeau (reporter) 2012-05-03 13:45	Something good to learn for you fdurand.

Issue History
Date Modified	Username	Field	Change
2011-09-14 16:31	obilodeau	New Issue
2012-05-03 13:44	obilodeau	Status	new => assigned
2012-05-03 13:44	obilodeau	Assigned To	=> fdurand
2012-05-03 13:45	obilodeau	Note Added: 0002696
2014-06-02 08:15	fdurand	Status	assigned => resolved
2014-06-02 08:15	fdurand	Resolution	open => fixed