0001399: option 82 logger doesnt work with cisco switches - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001399

PacketFence

dhcp

public

2012-03-15 10:39

2015-02-18 10:55

Reporter

maikel

Assigned To

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

open

Platform

OS Version

Product Version

devel

Target Version

investigate

Fixed in Version

Summary

0001399: option 82 logger doesnt work with cisco switches

Description

The newer PF versions use dhcp.pm from the libaries to look at option 82 messages in dhcp.

Older pf had still a shift functions in it to make the array work good for a cisco switch, but this got removed

For option82 + cisco this is needed:
--- /root/pf/lib/pf/util/dhcp.pm 2012-01-10 07:27:34.000000000 +0100
+++ dhcp.pm 2012-03-15 15:29:06.912135551 +0100
@@ -254,6 +254,10 @@
     my @option82 = @{$dhcp_ref->{'options'}{'82'}};
     while ( @option82 ) {
         my $subopt = shift( @option82 );
+ #This makes offset assumptions we probably shouldn't, but it should work fine for Cisco
+ shift( @option82 );
+ shift( @option82 );
+
         my $len = shift( @option82 );

         while ($len) {

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Attached Files

dhcp.txt [^] (505 bytes) 2012-03-15 10:39 [Show Content] [Hide Content]

--- /root/pf/lib/pf/util/dhcp.pm        2012-01-10 07:27:34.000000000 +0100
+++ dhcp.pm     2012-03-15 15:29:06.912135551 +0100
@@ -254,6 +254,10 @@
     my @option82 = @{$dhcp_ref->{'options'}{'82'}};
     while ( @option82 ) {
         my $subopt = shift( @option82 );
+        #This makes offset assumptions we probably shouldn't, but it should work fine for Cisco
+        shift( @option82 );
+        shift( @option82 );
+
         my $len = shift( @option82 );

         while ($len) {

Relationships

Notes
(0002618) maikel (reporter) 2012-03-16 07:47	It might also be an idea to store the Base ethernet MAC Address of the switch in the db or on a config file. A cisco relays option 82 sending the switch base mac adress. eg: INFO: Switch: 00:17:94:ec:08:00 Vlan 60 Mod 1 Port 12 DHCP (main::parse_dhcp_option82) Now again its nicer in the location log to mac2ip that arp adress, but pf simply doesnt know yet of that mac

(0003153) fgaudreault (viewer) 2012-10-19 12:19	Sent to the investigation queue.

(0003855) lmunro (administrator) 2015-02-18 10:55	Obsolete bug tracker entries. PF 4 introduced changes that either make these irrelevant or impossible to reproduce. New issues are moving to github issues.

Issue History
Date Modified	Username	Field	Change
2012-03-15 10:39	maikel	New Issue
2012-03-15 10:39	maikel	File Added: dhcp.txt
2012-03-16 07:47	maikel	Note Added: 0002618
2012-10-19 12:18	fgaudreault	Target Version	=> investigate
2012-10-19 12:19	fgaudreault	Note Added: 0003153
2015-02-18 10:55	lmunro	Note Added: 0003855
2015-02-18 10:55	lmunro	Status	new => closed