0000755: unhelpful packetfence error message when a switch module doesn't compile - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000755

PacketFence

public

2009-07-23 10:10

2011-01-26 15:43

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000755: unhelpful packetfence error message when a switch module doesn't compile

Description

When an SNMP switch module that is used by the configuration doesn't compile, you get this error message:

> Can't use string ("0") as a HASH ref while "strict refs" in use at
> /usr/local/pf/lib/pf/services.pm line 775 (0000001)
> (F) Only hard references are allowed by "strict refs". Symbolic
> references are disallowed. See perlref.

Not very helpful. I should wrap that loop in an eval or carp and try to give a bette explanation and maybe even fail gracefully, only ignoring this module and go on.

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Attached Files

Relationships

has duplicate

0000813

closed

obilodeau

When a switch doesn't compile, packetfence issues an error but then goes on like its normal

Notes
(0001333) rbalzard (administrator) 2009-10-15 14:19	fixed in revision 5815165026bd8d612710cba3cb088b9d3c931e80

(0001346) obilodeau (reporter) 2009-10-16 10:36	Review: - I would remove NEWS file entry, I consider this point covered by "error reporting fixes" - tests were added but I see no return() calls, are all the error cases carefully avoided by the if {} else ? - in vlan.pm: two lines are longer than 120, we should wrap them Aside from these little things, it looks fine, good work!

Issue History
Date Modified	Username	Field	Change
2009-07-23 10:10	obilodeau	New Issue
2009-07-23 10:10	obilodeau	Status	new => assigned
2009-07-23 10:10	obilodeau	Assigned To	=> obilodeau
2009-10-15 14:19	rbalzard	Note Added: 0001333
2009-10-15 14:20	rbalzard	Status	assigned => resolved
2009-10-15 14:20	rbalzard	Resolution	open => fixed
2009-10-16 10:12	obilodeau	Relationship added	has duplicate 0000813
2009-10-16 10:36	obilodeau	Note Added: 0001346
2011-01-26 15:43	obilodeau	Status	resolved => closed