0000863: web admin's node tab is slow when there are a lot of nodes - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000863

PacketFence

public

2009-11-30 15:05

2011-01-26 15:39

Reporter

obilodeau

Assigned To

rbalzard

Priority

high

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

1.9.0

Summary

0000863: web admin's node tab is slow when there are a lot of nodes

Description

my guess is that each node does a subselect and that's why its so long.

$node_view_all_sql
= "select node.mac,node.pid,node.detect_date,node.regdate,node.unregdate,node.lastskip,node.status,node.user_agent,node.computername,node.notes,node.last_arp,node.last_dhcp,node.dhcp_fingerprint,node.switch,node.port,node.vlan,ifnull(openviolations.nb,0) as nbopenviolations from node left join (select violation.mac,count(*) as nb from violation where status='open' group by violation.mac) as openviolations on node.mac=openviolations.mac";

the idea here is, should we limit the query to what we can see on the screen or should we optimize it?

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

df864b7289b1596a82abbfba30b3eee2688944b7

Attached Files

Relationships

Notes
(0001496) obilodeau (reporter) 2010-03-15 17:11	Fixed by Regis in branch 1.8. The problem was not missing limit clauses, they are appended automatically. The problem was in the subselect. Regis found a way to avoid subselect with grouping and using having instead of where clauses.

Issue History
Date Modified	Username	Field	Change
2009-11-30 15:05	obilodeau	New Issue
2009-11-30 15:05	obilodeau	Status	new => assigned
2009-11-30 15:05	obilodeau	Assigned To	=> obilodeau
2010-03-15 17:11	obilodeau	mtn revision	=> df864b7289b1596a82abbfba30b3eee2688944b7
2010-03-15 17:11	obilodeau	Note Added: 0001496
2010-03-15 17:11	obilodeau	Assigned To	obilodeau => rbalzard
2010-03-15 17:11	obilodeau	Status	assigned => resolved
2010-03-15 17:11	obilodeau	Resolution	open => fixed
2010-03-15 17:11	obilodeau	Fixed in Version	=> 1.8.8
2010-04-29 13:38	obilodeau	Fixed in Version	1.8.8 => 1.9.0
2011-01-26 15:39	obilodeau	Status	resolved => closed