0001055: deleting a node breaks paging - PacketFence

(0001640)
obilodeau (reporter)
2010-09-08 13:56

I'll try to reproduce it in the lab. Targeted for 1.9.1

(0001674)
obilodeau (reporter)
2010-09-17 10:40

reproductible

(0001675)
obilodeau (reporter)
2010-09-17 11:01

header.php takes care of deletion. in there you can find:

    if($_REQUEST['action'] == 'edit' || $_REQUEST['action'] == 'delete'){
      $my_table->refresh(); 
    }

Commenting out the refresh() prevented the issue.

action edit is unaffected by the issue so I'm not sure if ->refresh() does something bad or if it's the fact that the whole page is reloaded and that delete could badly setup the filters or something like that.

(0001676)
obilodeau (reporter)
2010-09-17 13:22

fixed it the cleanest way I could..

There's now a mechanism to tell the Table object that you require a special command to count number of rows in the table (allowing custom queries to be with set_count_cmd). Ported the node/view.php to this new functionality and updated Table->refresh() so that if there's a custom count query, then it needs to be updated.

fixed in 1.9 branch

Issue History
Date Modified	Username	Field	Change
2010-09-01 11:26	rafamiga	New Issue
2010-09-08 13:56	obilodeau	Note Added: 0001640
2010-09-08 13:56	obilodeau	Reproducibility	always => have not tried
2010-09-08 13:56	obilodeau	Target Version	=> 1.9.1
2010-09-17 10:40	obilodeau	Note Added: 0001674
2010-09-17 10:40	obilodeau	Assigned To	=> obilodeau
2010-09-17 10:40	obilodeau	Reproducibility	have not tried => always
2010-09-17 10:40	obilodeau	Status	new => assigned
2010-09-17 11:01	obilodeau	Note Added: 0001675
2010-09-17 13:22	obilodeau	mtn revision	=> d1d5b327064018d52f33a7030f69be8f2576c41b
2010-09-17 13:22	obilodeau	Note Added: 0001676
2010-09-17 13:22	obilodeau	Status	assigned => resolved
2010-09-17 13:22	obilodeau	Fixed in Version	=> 1.9.1
2010-09-17 13:22	obilodeau	Resolution	open => fixed
2011-01-26 15:38	obilodeau	Status	resolved => closed

Notes
(0001640) obilodeau (reporter) 2010-09-08 13:56	I'll try to reproduce it in the lab. Targeted for 1.9.1

(0001674) obilodeau (reporter) 2010-09-17 10:40	reproductible

(0001675) obilodeau (reporter) 2010-09-17 11:01	header.php takes care of deletion. in there you can find: if($_REQUEST['action'] == 'edit' \|\| $_REQUEST['action'] == 'delete'){ $my_table->refresh(); } Commenting out the refresh() prevented the issue. action edit is unaffected by the issue so I'm not sure if ->refresh() does something bad or if it's the fact that the whole page is reloaded and that delete could badly setup the filters or something like that.

(0001676) obilodeau (reporter) 2010-09-17 13:22	fixed it the cleanest way I could.. There's now a mechanism to tell the Table object that you require a special command to count number of rows in the table (allowing custom queries to be with set_count_cmd). Ported the node/view.php to this new functionality and updated Table->refresh() so that if there's a custom count query, then it needs to be updated. fixed in 1.9 branch

Relationships