0001068: print statement in pf::node::node_modify cause all sorts of problems - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001068

PacketFence

core

public

2010-09-14 15:11

2011-01-26 15:38

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

trivial

Reproducibility

sometimes

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

1.9.1

Fixed in Version

1.9.1

Summary

0001068: print statement in pf::node::node_modify cause all sorts of problems

Description

There are some tasks we have been working on where we faced problems that we tracked to the print statement in pf::node::node_modify.

- Putting the captive portal behind mod_perl for performance
- Using web services instead of raw SQL in our freeradius module (also behind mod_perl)

The error we face is that the code exercised makes a print statement before the HTTP Headers are sent by the SOAP stack which confuses the client-side.

One known regression if we were to remove this print statement is that pfdhcplistener relies on it to log stuff to stdout (which is redirected to a log file by packetfence) and there could be others...

Removing that statement will require us to carefully look at all node_modify's callers and understand if the print is a feature or not and perform the required to have the same print effect without disturbing apache/mod_perl.

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

ac261ee598f5cf3d73945aaa8079016f8e296fe5

Attached Files

Relationships

child of

0001010

closed

obilodeau

several SOAP issues

Notes
(0001670) obilodeau (reporter) 2010-09-15 15:59	and 'pfcmd node edit' calls too!

(0001672) obilodeau (reporter) 2010-09-15 17:17	Fix in branch 1.9. Did all that was required. See commit log entry for details.

Issue History
Date Modified	Username	Field	Change
2010-09-14 15:11	obilodeau	New Issue
2010-09-14 15:11	obilodeau	Status	new => assigned
2010-09-14 15:11	obilodeau	Assigned To	=> obilodeau
2010-09-14 15:12	obilodeau	Relationship added	child of 0001010
2010-09-15 15:59	obilodeau	Note Added: 0001670
2010-09-15 17:17	obilodeau	mtn revision	=> ac261ee598f5cf3d73945aaa8079016f8e296fe5
2010-09-15 17:17	obilodeau	Note Added: 0001672
2010-09-15 17:17	obilodeau	Status	assigned => resolved
2010-09-15 17:17	obilodeau	Fixed in Version	=> 1.9.1
2010-09-15 17:17	obilodeau	Resolution	open => fixed
2011-01-26 15:38	obilodeau	Status	resolved => closed