PacketFence
Bug Tracking System
Main | My View | View Issues | Change Log | Roadmap
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001353PacketFenceconfigurationpublic2011-12-29 09:262012-10-19 10:13
Reporterdwuelfrath 
Assigned Todwuelfrath 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionduplicate 
PlatformOSOS Version
Product Versiondevel 
Target Version3.4.0Fixed in Version3.4.0 
Summary0001353: configurator not finding interfaces
DescriptionThe function get_networkinfos actualy parses the output of “/sbin/ifconfig –a”

Trying to match for “inet addr” and “mask” (to make the mater short)

But our system is localized (in French ) so addr -à adr and mask -> masque …

It gave us an empty networks.conf that we had to populate by hand…

Without that, rerunning configurator.pl gave the error “Invalid existing networks configuration file :” at ./configurator.pl line 89

Solution:

Line 465 we made a modification …

If ( ( /inet addr:((?:\d{1,3}\.){3}\d{1,3}).+Mask:((?:\d{1,3}\.){3}\d{1,3})/ ) || ( /inet adr:((?:\d{1,3}\.){3}\d{1,3}).+Masque:((?:\d{1,3}\.){3}\d{1,3})/ ) ) {

So now it detects the interfaces ….

Question:

 1) why not using /sbin/ip (from iproute package)

2) the script include the Net::Interface module why not using this ?
TagsNo tags attached.
fixed in git revision
fixed in mtn revision
Attached Files? file icon perl_pmask.pm [^] (1,565 bytes) 2012-01-17 07:17
? file icon get_networkinfos.pm [^] (1,479 bytes) 2012-01-17 07:18

- Relationships
duplicate of 0001418closedobilodeau configurator.pl does not work correctly under a french localized CentOS 6.2 
child of 0001444closed web-based configuration wizard 

-  Notes
(0002492)
obilodeau (reporter)
2011-12-30 11:37

 A solution like that is not viable since the regexp will have to be adapted to every language.

Naive fix would be to add LC_ALL=C before calling ifconfig so that it will output in english.

Good fix would be to port to a perl interface like Net::Interface. It has not been done because Net::Interface dependency was added when we added a feature and we did not modify the old working code to avoid breaking things.

The /sbin/ip solution would have the same problem as ifconfig's: localized output strings.
(0002538)
dwygodzki (reporter)
2012-01-17 07:19

 just have reworked the sub to use net::interface , not yet fully tested .
(0002817)
dwygodzki (reporter)
2012-06-20 05:19

 resolved by 001418 now
(0002819)
obilodeau (reporter)
2012-06-21 20:25

 Sorry if we haven't used your patch but as you can hear on the -devel list and on github we are working on a web-based configurator and we are actually in extensive testing phase now so we didn't want to invest the time in switching to N::I and honestly I didn't see the email with your patch pass..

Thanks for letting us know it's fixed. I'm closing this.

- Issue History
Date Modified Username Field Change
2011-12-29 09:26 dwuelfrath New Issue
2011-12-29 09:26 dwuelfrath Status new => assigned
2011-12-29 09:26 dwuelfrath Assigned To => dwuelfrath
2011-12-30 11:37 obilodeau Note Added: 0002492
2012-01-17 07:17 dwygodzki File Added: perl_pmask.pm
2012-01-17 07:18 dwygodzki File Added: get_networkinfos.pm
2012-01-17 07:19 dwygodzki Note Added: 0002538
2012-05-07 15:35 obilodeau Relationship added child of 0001444
2012-06-20 05:19 dwygodzki Note Added: 0002817
2012-06-21 20:25 obilodeau Note Added: 0002819
2012-06-21 20:26 obilodeau Relationship added duplicate of 0001418
2012-06-21 20:27 obilodeau Status assigned => closed
2012-06-21 20:27 obilodeau Resolution open => duplicate
2012-06-21 20:27 obilodeau Fixed in Version => 3.4.0
2012-10-19 10:13 fgaudreault Target Version +1 => 3.4.0

Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker