| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0001385 | PacketFence | addons | public | 2012-02-28 11:52 | 2012-04-23 11:03 |
|
| Reporter | obilodeau | |
| Assigned To | obilodeau | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | | |
| Target Version | 3.3.0 | Fixed in Version | 3.3.0 | |
|
| Summary | 0001385: proxy bypass doesn't work if you have a virtual IP |
| Description | The virtual IP is what is exposed to the IP resolver instead of 127.0.0.1. |
| Tags | No tags attached. |
|
| fixed in git revision | |
| fixed in mtn revision | |
|
| Attached Files |  proxy-bypass-with-vip-fix-1385.patch [^] (1,111 bytes) 2012-02-28 12:33 [Show Content] [Hide Content]#
# old_revision [b22fdb5595a19135265056db40739345c43ad1b8]
#
# patch "pf/lib/pf/web.pm"
# from [c03df2242eb2580529a870197cebc9559b636f94]
# to [b8e9281c9aac6b9b10aabb56e03641400a943695]
#
============================================================
--- pf/lib/pf/web.pm c03df2242eb2580529a870197cebc9559b636f94
+++ pf/lib/pf/web.pm b8e9281c9aac6b9b10aabb56e03641400a943695
@@ -742,8 +742,16 @@ sub get_client_ip {
# if user is behind a proxy it's not sufficient since we'll get the proxy's IP
my $directly_connected_ip = $cgi->remote_addr();
+ # every source IP in this table are considered to be from a proxied source
+ my %proxied_lookup = (
+ $LOOPBACK_IPV4 => 1,
+ );
+ # adding virtual IP if one is present
+ $proxied_lookup{$management_network->tag('vip')} = 1 if ($management_network->tag('vip'));
+
# handling most common case first
- if ($directly_connected_ip ne $LOOPBACK_IPV4) {
+ # if this is NOT from one of the expected proxy IPs return the IP
+ if (!$proxied_lookup{$directly_connected_ip}) {
return $directly_connected_ip;
}
|
|
Relationships 
Relationships 