0001441: warnings in pfsetvlan when a switch's mode=... is not set - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001441

PacketFence

core

public

2012-05-02 15:29

2015-02-13 15:42

Reporter

obilodeau

Assigned To

Priority

normal

Severity

tweak

Reproducibility

sometimes

Status

closed

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0001441: warnings in pfsetvlan when a switch's mode=... is not set

Description

Warning is "Use of uninitialized value in string eq at /usr/local/pf/sbin/pfsetvlan line 626" in logs/packetfence.log

if ( $config{$switch_ip}{'mode'} eq 'ignore' ) {
    $logger->info("We have received a trap from switch $switch_ip. This switch is in 'ignore' 
mode. Flush the trap");
    return;
}

I think warning happens on switches that don't have an explicit mode=... for their own instance and rely on the default inherited value instead.

Fix: the $config hash should hold default values too or switchFactory should provide a higher-level construct to verify the mode and that the switch exists. Grabbing %{ $switchFactory->{_config} } is probably expensive on large conf/switches.conf anyways.

Seen on 3.3.2 but probably present since ages.

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Attached Files

Relationships

Notes
(0003800) lmunro (administrator) 2015-02-13 15:42	These bugs have been sitting untouched since 2012. Closing them and possibly reopening in github tracker where relevant.

Issue History
Date Modified	Username	Field	Change
2012-05-02 15:29	obilodeau	New Issue
2015-02-13 15:42	lmunro	Note Added: 0003800
2015-02-13 15:42	lmunro	Status	new => closed