0000469: use more constants throughout the modules - PacketFence - BTS

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0000469

PacketFence

refactoring

public

2008-11-07 16:49

2015-02-13 15:35

Reporter

obilodeau

Assigned To

Priority

normal

Severity

tweak

Reproducibility

always

Status

closed

Resolution

open

Platform

OS

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000469: use more constants throughout the modules

Description

Lets aim for 0% of magic strings or numbers.

Use 'use constant' when possible but remember limitation that in some places (like method calls) you need to prevent bareword quoting (with a +). In these cases, I think a 'use Readonly;' with a $ALL_CAPS variable is more readable and will die on attempts to redefine.

If you didn't get any of the above, ask Olivier what to do ;)

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Relationships

parent of

resolved

hardcoded 'reg' and 'unreg' node status should be refactored into constants

Notes
(0001527) obilodeau (reporter) 2010-05-04 13:48	Seems like mantis doesn't like updating a bug with a deleted user. Setting reporter to myself.

(0003742) lmunro (administrator) 2015-02-13 15:35	No longer relevant.

Issue History
Date Modified	Username	Field	Change
2008-11-07 16:49	user4	New Issue
2009-01-12 13:25	user4	Category	1.8.0 => 1.8.1
2009-03-03 15:21	user4	Category	1.8.1 => 1.8.2
2009-04-13 13:35	user4	Category	1.8.2 => 1.8.3
2009-06-05 08:53	user4	Project	PacketFence => PacketFence 1.9
2010-04-15 17:43	obilodeau	Project	PacketFence 1.9 => PacketFence
2010-05-04 13:46	obilodeau	Status	new => assigned
2010-05-04 13:46	obilodeau	Assigned To	=> obilodeau
2010-05-04 13:47	obilodeau	Reporter	user4 => aarchi10
2010-05-04 13:47	obilodeau	Severity	feature => tweak
2010-05-04 13:47	obilodeau	Category	=> refactoring
2010-05-04 13:48	obilodeau	Note Added: 0001527
2010-05-04 13:48	obilodeau	Reporter	aarchi10 => obilodeau
2010-05-04 13:48	obilodeau	Relationship added	parent of 0000915
2010-05-04 13:51	obilodeau	Description Updated
2011-01-18 11:43	obilodeau	Target Version	=> trunk
2012-10-19 15:03	fgaudreault	Assigned To	obilodeau =>
2012-10-19 15:03	fgaudreault	Target Version	devel => general
2015-02-13 15:35	lmunro	Note Added: 0003742
2015-02-13 15:35	lmunro	Status	assigned => closed

Copyright © 2000 - 2012 MantisBT Group