0000874: pfcmd_vlan should log at the same place as everyone else - PacketFence

(0001623)
obilodeau (reporter)
2010-08-04 09:57

Once the fix is committed open a new feature request to have the output duplicated to stdout if the -verbose flag is present (with log4perl levels):

       -verbose             log verbosity level
                              0 : fatal messages
                              1 : warn messages
                              2 : info messages
                              3 : debug
                              4 : trace

Or implement it right away if it's easy to do with log4perl and it sounds valuable.

(0001624)
obilodeau (reporter)
2010-08-04 09:58

patch from Josh:

--- pf2010/bin/pfcmd_vlan	2010/07/07 21:26:56	1
+++ pf2010/bin/pfcmd_vlan	2010/08/02 20:16:16	59
@@ -215,12 +215,13 @@
 } else {
     $logLevel = $TRACE;
 }
-Log::Log4perl->easy_init(
-    {   level  => $logLevel,
-        layout => '%d (%r) %M%n    %m %n'
-    }
-);
-my $logger = Log::Log4perl->get_logger('');
+#Log::Log4perl->easy_init(
+#    {   level  => $logLevel,
+#        layout => '%d (%r) %M%n    %m %n'
+#    }
+#);
+Log::Log4perl->init("/usr/local/pf/conf/log.conf");
+my $logger = Log::Log4perl->get_logger('pfcmd_vlan');

 my $switchFactory = new pf::SwitchFactory(
     -configFile => INSTALL_DIR . '/conf/switches.conf' );

(0001780)
obilodeau (reporter)
2010-11-26 11:26

pfcmd_vlan now logs to logs/packetfence.log and if -verbose flag is on, it'll log both to STDOUT and logs/packetfence.log

Issue History
Date Modified	Username	Field	Change
2009-12-08 20:08	obilodeau	New Issue
2009-12-08 20:08	obilodeau	Status	new => assigned
2009-12-08 20:08	obilodeau	Assigned To	=> obilodeau
2010-04-15 17:43	obilodeau	Project	PacketFence 1.9 => PacketFence
2010-08-04 09:57	obilodeau	Note Added: 0001623
2010-08-04 09:57	obilodeau	Target Version	=> 1.10.0
2010-08-04 09:58	obilodeau	Note Added: 0001624
2010-11-19 14:25	obilodeau	Target Version	1.10.0 => 2.0.0
2010-11-26 11:20	obilodeau	Relationship added	related to 0001130
2010-11-26 11:26	obilodeau	mtn revision	=> 6272b83016fe4f8264cbfdce928af5b55cd32b15
2010-11-26 11:26	obilodeau	Note Added: 0001780
2010-11-26 11:26	obilodeau	Status	assigned => resolved
2010-11-26 11:26	obilodeau	Fixed in Version	=> trunk
2010-11-26 11:26	obilodeau	Resolution	open => fixed
2010-12-15 11:37	obilodeau	Fixed in Version	trunk => 2.0.0
2011-01-26 15:42	obilodeau	Status	resolved => closed

Notes
(0001623) obilodeau (reporter) 2010-08-04 09:57	Once the fix is committed open a new feature request to have the output duplicated to stdout if the -verbose flag is present (with log4perl levels): -verbose log verbosity level 0 : fatal messages 1 : warn messages 2 : info messages 3 : debug 4 : trace Or implement it right away if it's easy to do with log4perl and it sounds valuable.

(0001624) obilodeau (reporter) 2010-08-04 09:58	patch from Josh: --- pf2010/bin/pfcmd_vlan 2010/07/07 21:26:56 1 +++ pf2010/bin/pfcmd_vlan 2010/08/02 20:16:16 59 @@ -215,12 +215,13 @@ } else { $logLevel = $TRACE; } -Log::Log4perl->easy_init( - { level => $logLevel, - layout => '%d (%r) %M%n %m %n' - } -); -my $logger = Log::Log4perl->get_logger(''); +#Log::Log4perl->easy_init( +# { level => $logLevel, +# layout => '%d (%r) %M%n %m %n' +# } +#); +Log::Log4perl->init("/usr/local/pf/conf/log.conf"); +my $logger = Log::Log4perl->get_logger('pfcmd_vlan'); my $switchFactory = new pf::SwitchFactory( -configFile => INSTALL_DIR . '/conf/switches.conf' );

(0001780) obilodeau (reporter) 2010-11-26 11:26	pfcmd_vlan now logs to logs/packetfence.log and if -verbose flag is on, it'll log both to STDOUT and logs/packetfence.log