0000890: we need local deassociate / dot11deAuthenticate traps for registration / isolation to work properly on wireless - PacketFence

(0001454)
obilodeau (reporter)
2010-01-13 17:36

if you are bitten by this, right now you can apply the following patch until we do a release:

#
# old_revision [0ec2fb1de198850e403ac44ebae47a7f206ee51c]
#
# patch "pf/lib/pf/vlan.pm"
#  from [804c8a96848f4ba25c0dd8f86fbaa12854714ba5]
#    to [7543ef21e77148ed2d91512a41da2e794dfdff57]
#
============================================================
--- pf/lib/pf/vlan.pm	804c8a96848f4ba25c0dd8f86fbaa12854714ba5
+++ pf/lib/pf/vlan.pm	7543ef21e77148ed2d91512a41da2e794dfdff57
@@ -142,9 +142,13 @@ sub custom_doWeActOnThisTrap {
         return 1;
     }
     if ( $trapType eq 'dot11Deauthentication' ) {
-        # we no longer act on dot11Deauth traps see bug 0000880
-        # http://www.packetfence.org/mantis/view.php?id=880 [^]
-        return 0;
+        if ($switch->{_ip} eq '127.0.0.1') {
+            return 1;
+        } else {
+            # we no longer act on non-local dot11Deauth traps see bug 0000880
+            # http://www.packetfence.org/mantis/view.php?id=880 [^]
+            return 0;
+        }
     }
 
     my $ifType = $switch->getIfType($ifIndex);

(0001455)
obilodeau (reporter)
2010-01-13 17:58

I need to do more testing to confirm this one, the code path is impossible to reach. I added more logging and i'll retest before confirming this is actually a bug.

(0001553)
obilodeau (reporter)
2010-05-05 14:09

We will try to look at it for 1.9.1.

(0001665)
obilodeau (reporter)
2010-09-15 13:14

Reminder sent to: rbalzard

I'm confused by this one. We will need to look at it and talk about it together.

(0001819)
obilodeau (reporter)
2011-01-18 15:19

dot11Deauthenticate traps are not required for proper isolation, only for proper locationlog management.

dot11Deauthenticate traps should never be sent by 127.0.0.1 so this fix is irrelevant.

deAssociate traps are sent from 127.0.0.1 and we should act upon them which the code currently does.

Issue History
Date Modified	Username	Field	Change
2010-01-13 17:35	obilodeau	New Issue
2010-01-13 17:35	obilodeau	Status	new => assigned
2010-01-13 17:35	obilodeau	Assigned To	=> obilodeau
2010-01-13 17:35	obilodeau	Relationship added	related to 0000880
2010-01-13 17:36	obilodeau	Note Added: 0001454
2010-01-13 17:58	obilodeau	Note Added: 0001455
2010-01-13 17:58	obilodeau	Resolution	open => unable to reproduce
2010-05-05 14:09	obilodeau	Note Added: 0001553
2010-05-05 14:09	obilodeau	Category	1.8.7 => regression
2010-05-05 14:09	obilodeau	Target Version	=> 1.9.1
2010-09-15 13:14	obilodeau	Note Added: 0001665
2010-09-22 16:05	obilodeau	Target Version	1.9.1 => 1.9.2
2010-11-19 14:24	obilodeau	Target Version	1.9.2 => 2.0.0
2011-01-18 15:07	obilodeau	Target Version	2.0.0 => 2.0.1
2011-01-18 15:19	obilodeau	Note Added: 0001819
2011-01-18 15:19	obilodeau	Status	assigned => resolved
2011-01-18 15:19	obilodeau	Fixed in Version	=> 1.8.7
2011-01-18 15:19	obilodeau	Resolution	unable to reproduce => no change required
2011-05-04 11:51	obilodeau	Status	resolved => closed

Notes
(0001454) obilodeau (reporter) 2010-01-13 17:36	if you are bitten by this, right now you can apply the following patch until we do a release: # # old_revision [0ec2fb1de198850e403ac44ebae47a7f206ee51c] # # patch "pf/lib/pf/vlan.pm" # from [804c8a96848f4ba25c0dd8f86fbaa12854714ba5] # to [7543ef21e77148ed2d91512a41da2e794dfdff57] # ============================================================ --- pf/lib/pf/vlan.pm 804c8a96848f4ba25c0dd8f86fbaa12854714ba5 +++ pf/lib/pf/vlan.pm 7543ef21e77148ed2d91512a41da2e794dfdff57 @@ -142,9 +142,13 @@ sub custom_doWeActOnThisTrap { return 1; } if ( $trapType eq 'dot11Deauthentication' ) { - # we no longer act on dot11Deauth traps see bug 0000880 - # http://www.packetfence.org/mantis/view.php?id=880 [^] - return 0; + if ($switch->{_ip} eq '127.0.0.1') { + return 1; + } else { + # we no longer act on non-local dot11Deauth traps see bug 0000880 + # http://www.packetfence.org/mantis/view.php?id=880 [^] + return 0; + } } my $ifType = $switch->getIfType($ifIndex);

(0001455) obilodeau (reporter) 2010-01-13 17:58	I need to do more testing to confirm this one, the code path is impossible to reach. I added more logging and i'll retest before confirming this is actually a bug.

(0001553) obilodeau (reporter) 2010-05-05 14:09	We will try to look at it for 1.9.1.

(0001665) obilodeau (reporter) 2010-09-15 13:14	Reminder sent to: rbalzard I'm confused by this one. We will need to look at it and talk about it together.

(0001819) obilodeau (reporter) 2011-01-18 15:19	dot11Deauthenticate traps are not required for proper isolation, only for proper locationlog management. dot11Deauthenticate traps should never be sent by 127.0.0.1 so this fix is irrelevant. deAssociate traps are sent from 127.0.0.1 and we should act upon them which the code currently does.