0000987: authorizeMAC of Cisco Catalyst 2960 has a bug - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000987

PacketFence

hardware modules

public

2010-05-07 14:01

2011-01-26 15:44

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

2.0.1

Fixed in Version

2.0.1

Summary

0000987: authorizeMAC of Cisco Catalyst 2960 has a bug

Description

When authorizing a MAC, $deauthVlan is used instead of $authVlan.

    if ($authMac) {
        my @macArray = split( /:/, $authMac );
        my $completeOid
            = $oid_cpsIfVlanSecureMacAddrRowStatus . "." . $ifIndex;
        foreach my $macPiece (@macArray) {
            $completeOid .= "." . hex($macPiece);
        }
        $completeOid .= "." . $deauthVlan;
        push @oid_value, ( $completeOid, Net::SNMP::INTEGER, 4 );
    }

Was this done on purpose or not, we don't remember.

What we know is: right now, it works. Maybe that's because we do a setVlan first and send ->getVlan() in $deauth.

It happened around:
original submission, correct: e8ce7939919e9d4d41579a296e587aaf91870710
disapproval of above: 646e4f68ca997c4432cec6fcd32cbb483803ffa9
re-submission with bug: 1f09da52ab499fe94fa1c325b27e56232222c23d

We won't do it for 1.9.0 but for next feature release, we will try to do the right thing in there.

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

331ededae74131a807216827bc739919a5b83c16

Attached Files

Relationships

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2010-05-07 14:01	obilodeau	New Issue
2010-05-07 14:01	obilodeau	Status	new => assigned
2010-05-07 14:01	obilodeau	Assigned To	=> obilodeau
2010-11-19 14:25	obilodeau	Target Version	1.10.0 => 2.0.0
2011-01-18 09:47	obilodeau	Target Version	2.0.0 => 2.0.1
2011-01-21 15:08	fgaudreault	mtn revision	=> 331ededae74131a807216827bc739919a5b83c16
2011-01-21 15:08	fgaudreault	Status	assigned => resolved
2011-01-21 15:08	fgaudreault	Fixed in Version	=> 2.0.1
2011-01-21 15:08	fgaudreault	Resolution	open => fixed
2011-01-26 15:44	obilodeau	Status	resolved => closed