PacketFence
Bug Tracking System

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001414PacketFencecorepublic2012-03-30 11:592012-04-18 10:07
Reporterfgaudreault 
Assigned Tofgaudreault 
PrioritynormalSeveritytweakReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.2.0 
Target Version3.3.0Fixed in Version3.3.0 
Summary0001414: Improve performance of node accounting
DescriptionSince now the CoA heavily relies on accounting to perform deauth, and that more people are interested on the BW violations, it is important that this part of the software works, and that is works fast.

This ticket is about potential improvements of the accounting part :
- Missing an index in the radacct table on the callingstationid field (we use this field in where clause, it is a pain on huge tables :S)
- Trim the radacct_log table when we have an acct-stop (remove interims). Since accounting stop contains the total packets, we can get rid of "useless" interim entries.
- Remove sessions that are more than 1 years old

TagsNo tags attached.
fixed in git revision3c9f6fd30ea95f2f6b49a5840f12d1ee9adb2bd5, d0d74d7ec245b857e8299f791af9e05b7e18cef0
fixed in mtn revision
Attached Files

- Relationships

-  Notes
(0002632)
fgaudreault (viewer)
2012-03-30 13:45
edited on: 2012-03-30 13:46

For issue 1 :
- We need to add the following to the upgrade-3.2.0-3.3.0.sql :
CREATE INDEX callingstationid ON radacct ( callingstationid );
- We need to adjust the schema with a KEY on callingstationid

For issue 2:
- We can't. We need to keep Interims. This is to add precisions to the bw usage calculation.

For issue 3:
- we need to add a statement in the backup script to delete sessions from the previous years. (< YEAR(CURRENT_DATE()))

That means on January, stats would be reset to 0 for everyone. Maybe it is not optimal, but for many of you, I am sure it is OK. If not let us know, we can move them to an history table in order to get a "last year" metric.

(0002633)
fgaudreault (viewer)
2012-03-30 14:57

Waiting for feature merge prior doing issue 1 commit. Feature 3 is committed in devel.
(0002644)
fgaudreault (viewer)
2012-04-12 11:58

Fixed and commit to stable.
(0002663)
obilodeau (reporter)
2012-04-18 10:07

fixed released last friday

- Issue History
Date Modified Username Field Change
2012-03-30 11:59 fgaudreault New Issue
2012-03-30 13:45 fgaudreault Note Added: 0002632
2012-03-30 13:46 fgaudreault Note Edited: 0002632
2012-03-30 14:56 fgaudreault git revision => 3c9f6fd30ea95f2f6b49a5840f12d1ee9adb2bd5
2012-03-30 14:57 fgaudreault Note Added: 0002633
2012-04-12 11:58 fgaudreault git revision 3c9f6fd30ea95f2f6b49a5840f12d1ee9adb2bd5 => 3c9f6fd30ea95f2f6b49a5840f12d1ee9adb2bd5, d0d74d7ec245b857e8299f791af9e05b7e18cef0
2012-04-12 11:58 fgaudreault Note Added: 0002644
2012-04-12 11:58 fgaudreault Status new => resolved
2012-04-12 11:58 fgaudreault Resolution open => fixed
2012-04-12 11:58 fgaudreault Assigned To => fgaudreault
2012-04-18 10:04 obilodeau Fixed in Version => 3.3.0
2012-04-18 10:04 obilodeau Target Version => 3.3.0
2012-04-18 10:07 obilodeau Note Added: 0002663
2012-04-18 10:07 obilodeau Status resolved => closed


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker