PacketFence - BTS - PacketFence
View Issue Details
0000992PacketFenceconfigurationpublic2010-05-25 11:292012-02-29 10:46
obilodeau 
fgaudreault 
normalfeatureN/A
closedfixed 
 
2.2.02.2.0 
ad7c3a01bf6b69908f318ae0ed69fb826a78bc02
0000992: validation should be performed on trigger ranges
Right now a wrong trigger range will be accepted on startup. Validation on startup should check for that.

ex: Detect::100-50 is invalid since 50 < 100 but pf won't tell and the violation will never trigger.

A simple test after the parsing is performed would be enough.
Code Review
related to 0000749assigned fgaudreault Violation load does not validate if 2 violations have the same ID 
patch checkup.patch (1,987) 2011-03-23 14:08
https://www.packetfence.org/bugs/file_download.php?file_id=84&type=bug
Issue History
2010-05-25 11:29obilodeauNew Issue
2010-05-25 11:29obilodeauStatusnew => assigned
2010-05-25 11:29obilodeauAssigned To => obilodeau
2010-11-19 14:25obilodeauTarget Version1.10.0 => 2.0.0
2011-01-18 09:30obilodeauTarget Version2.0.0 => 2.1.0
2011-03-03 15:16obilodeauTarget Version2.1.0 => +1
2011-03-03 15:18obilodeauTarget Version+1 => +2
2011-03-23 14:07fgaudreaultAssigned Toobilodeau => fgaudreault
2011-03-23 14:08fgaudreaultNote Added: 0001981
2011-03-23 14:08fgaudreaultFile Added: checkup.patch
2011-03-23 14:08fgaudreaultTag Attached: Code Review
2011-03-23 14:09fgaudreaultStatusassigned => feedback
2011-04-04 14:24fgaudreaultRelationship addedrelated to 0000749
2011-05-02 17:59obilodeaumtn revision => ad7c3a01bf6b69908f318ae0ed69fb826a78bc02
2011-05-02 17:59obilodeauNote Added: 0002048
2011-05-02 17:59obilodeauStatusfeedback => resolved
2011-05-02 17:59obilodeauFixed in Version => trunk
2011-05-02 17:59obilodeauResolutionopen => fixed
2011-05-04 11:33obilodeauFixed in Versiontrunk => 2.2.0
2011-05-04 11:40obilodeauStatusresolved => closed
2011-10-25 09:05obilodeauTarget Version+2 => 2.2.0
2012-02-29 10:46obilodeauCategoryfeature => configuration

Notes
(0001981)
fgaudreault   
2011-03-23 14:08   
Added a patch. Apply on vanilla 2.1.0
(0002048)
obilodeau   
2011-05-02 17:59   
Violation class validation in pfcmd's checkup. Fixes 0000992;

Added validation on trigger ranges but it opens the way for more violation validation.
- refactoring: isolated trigger interpretation in pf::trigger
- new trigger.t unit test
- checkup messages with a \n won't output two \n
Original work from Francois, clean-up and additional work by Olivier.
http://www.packetfence.org/bugs/view.php?id=992 [^]