PacketFence
Bug Tracking System

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000992PacketFenceconfigurationpublic2010-05-25 11:292012-02-29 10:46
Reporterobilodeau 
Assigned Tofgaudreault 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version2.2.0Fixed in Version2.2.0 
Summary0000992: validation should be performed on trigger ranges
DescriptionRight now a wrong trigger range will be accepted on startup. Validation on startup should check for that.

ex: Detect::100-50 is invalid since 50 < 100 but pf won't tell and the violation will never trigger.

A simple test after the parsing is performed would be enough.
TagsCode Review
fixed in git revision
fixed in mtn revisionad7c3a01bf6b69908f318ae0ed69fb826a78bc02
Attached Filespatch file icon checkup.patch [^] (1,987 bytes) 2011-03-23 14:08 [Show Content]

- Relationships
related to 0000749assignedfgaudreault Violation load does not validate if 2 violations have the same ID 

-  Notes
(0001981)
fgaudreault (viewer)
2011-03-23 14:08

Added a patch. Apply on vanilla 2.1.0
(0002048)
obilodeau (reporter)
2011-05-02 17:59

Violation class validation in pfcmd's checkup. Fixes 0000992;

Added validation on trigger ranges but it opens the way for more violation validation.
- refactoring: isolated trigger interpretation in pf::trigger
- new trigger.t unit test
- checkup messages with a \n won't output two \n
Original work from Francois, clean-up and additional work by Olivier.
http://www.packetfence.org/bugs/view.php?id=992 [^]

- Issue History
Date Modified Username Field Change
2010-05-25 11:29 obilodeau New Issue
2010-05-25 11:29 obilodeau Status new => assigned
2010-05-25 11:29 obilodeau Assigned To => obilodeau
2010-11-19 14:25 obilodeau Target Version 1.10.0 => 2.0.0
2011-01-18 09:30 obilodeau Target Version 2.0.0 => 2.1.0
2011-03-03 15:16 obilodeau Target Version 2.1.0 => +1
2011-03-03 15:18 obilodeau Target Version +1 => +2
2011-03-23 14:07 fgaudreault Assigned To obilodeau => fgaudreault
2011-03-23 14:08 fgaudreault Note Added: 0001981
2011-03-23 14:08 fgaudreault File Added: checkup.patch
2011-03-23 14:08 fgaudreault Tag Attached: Code Review
2011-03-23 14:09 fgaudreault Status assigned => feedback
2011-04-04 14:24 fgaudreault Relationship added related to 0000749
2011-05-02 17:59 obilodeau mtn revision => ad7c3a01bf6b69908f318ae0ed69fb826a78bc02
2011-05-02 17:59 obilodeau Note Added: 0002048
2011-05-02 17:59 obilodeau Status feedback => resolved
2011-05-02 17:59 obilodeau Fixed in Version => trunk
2011-05-02 17:59 obilodeau Resolution open => fixed
2011-05-04 11:33 obilodeau Fixed in Version trunk => 2.2.0
2011-05-04 11:40 obilodeau Status resolved => closed
2011-10-25 09:05 obilodeau Target Version +2 => 2.2.0
2012-02-29 10:46 obilodeau Category feature => configuration


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker