0001157: dot11Deauthentication traps causing warnings and potentially crashing threads - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001157

PacketFence

public

2011-01-18 15:42

2011-01-26 15:44

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

minor

Reproducibility

random

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.0.0

Target Version

2.0.1

Fixed in Version

2.0.1

Summary

0001157: dot11Deauthentication traps causing warnings and potentially crashing threads

Description

Since the refactoring of pfsetvlan, hard-coded trapIfIndex = 'WIFI' for dot11Deauth traps disappeared from the code.

trapIfIndex is then assigned to switch_port. Then it creates a problem because the thread-safe shared data structure is relying on the presence of switch_port throughout pfsetvlan. When it's trying to print it and it's undef bang! When it's calling SQL (traplog_insert) bang!..

Severity is minor because such traps should be disabled by default.

Fix this and remember
- Remaining hard-coded trapIfIndex = 'WIFI' calls should be removed. HP and Extricom are guilty.

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

32140b9d364221adfed25780343917fedcefa3f1

Attached Files

Relationships

Notes
(0001820) obilodeau (reporter) 2011-01-18 16:15	Setting switch_port to temporary 'WIFI' value for dot11Deauthentication traps in pfsetvlan's parseTrap. This solves warnings and potential crashers when receiving dot11Deauthentication traps (which should not be the default case). Also removed pf::SNMP::... references to trapIfIndex = 'WIFI' and re-enabled HP's Controllers parseTrap.

Issue History
Date Modified	Username	Field	Change
2011-01-18 15:42	obilodeau	New Issue
2011-01-18 15:50	obilodeau	Status	new => assigned
2011-01-18 15:50	obilodeau	Assigned To	=> obilodeau
2011-01-18 16:15	obilodeau	mtn revision	=> 32140b9d364221adfed25780343917fedcefa3f1
2011-01-18 16:15	obilodeau	Note Added: 0001820
2011-01-18 16:15	obilodeau	Status	assigned => resolved
2011-01-18 16:15	obilodeau	Fixed in Version	=> 2.0.1
2011-01-18 16:15	obilodeau	Resolution	open => fixed
2011-01-26 15:44	obilodeau	Status	resolved => closed