0001485: pf::web::guest / admin guest creation need some kind of separation - PacketFence - BTS

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0001485

PacketFence

core

public

2012-07-10 15:55

2012-10-19 13:46

Reporter

dwuelfrath

Assigned To

Priority

normal

Severity

feature

Reproducibility

N/A

Status

resolved

Resolution

open

Platform

OS

OS Version

Product Version

devel

Target Version

3.6.0

Fixed in Version

devel

Summary

0001485: pf::web::guest / admin guest creation need some kind of separation

Description

It's seems like there's code "reutilization" but in a strange way...
guest creation (preregistered) should be "admin stuff" and for the moment there's a strong link with portal methods

Additional Information

new portal profiles uses a portalSession object which is not meant to be used on the admin side. Since some methods in the guests preregistration workflow are the same as the ones used for different captive portal pages generation, there's some kind of conflict

There should also have a real distinction between these concepts (templates, cgi, generation methods)

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Relationships

related to	0001507	closed	obilodeau	Web extension point (pf::web::custom) no longer works in 3.5.0
related to	0001518	closed	obilodeau	guest management login doesn't work

Notes
(0002827) dwuelfrath (administrator) 2012-07-11 16:22	- should a real distinction between admin web and portal web... admin should include guest_admin_reg - different templates used for guest self registration and guest admin registration (put these templates elsewhere...) - pf::web::generate_error_page <-> pf::web::generate_admin_error_page ONCE DONE: - inline get_client_ip in new pf::Portal::Session stuff - standardize the way of calling templates, variables VS non-variables, ..

(0002983) obilodeau (reporter) 2012-08-28 15:02	work started in branch: fix/1485-web-guest-vs-admin-separation See: https://github.com/inverse-inc/packetfence/commits/fix/1485-web-guest-vs-admin-separation [^]

(0002990) obilodeau (reporter) 2012-08-29 16:13	I'm done with this here. See the changes: https://github.com/inverse-inc/packetfence/compare/fix/apache-acl-generation-for-guests...fix/1485-web-guest-vs-admin-separation [^] Once the pull request for fix/apache-acl-generation-for-guests will be merged, I'm going to open a pull request for fix/1485-web-guest-vs-admin-separation. Doing so because the latter branch was derived from the former branch.

(0003055) obilodeau (reporter) 2012-09-12 14:01	pull request opened: https://github.com/inverse-inc/packetfence/pull/60 [^]

Issue History
Date Modified	Username	Field	Change
2012-07-10 15:55	dwuelfrath	New Issue
2012-07-11 16:22	dwuelfrath	Note Added: 0002827
2012-08-08 10:49	obilodeau	Relationship added	related to 0001507
2012-08-28 15:01	obilodeau	Status	new => assigned
2012-08-28 15:01	obilodeau	Assigned To	=> obilodeau
2012-08-28 15:02	obilodeau	Note Added: 0002983
2012-08-29 16:00	obilodeau	Relationship added	related to 0001518
2012-08-29 16:13	obilodeau	Note Added: 0002990
2012-09-12 14:01	obilodeau	Note Added: 0003055
2012-10-19 13:46	fgaudreault	Assigned To	obilodeau =>
2012-10-19 13:46	fgaudreault	Status	assigned => resolved
2012-10-19 13:46	fgaudreault	Fixed in Version	=> devel
2012-10-19 13:46	fgaudreault	Target Version	=> 3.6.0

Copyright © 2000 - 2012 MantisBT Group