View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
ID | Project | Category | View Status | Date Submitted | Last Update |
0001507 | PacketFence | | public | 2012-08-08 10:46 | 2012-09-06 10:57 |
|
Reporter | obilodeau | |
Assigned To | obilodeau | |
Priority | high | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | | OS Version | |
Product Version | 3.5.0 | |
Target Version | 3.5.1 | Fixed in Version | 3.5.1 | |
|
Summary | 0001507: Web extension point (pf::web::custom) no longer works in 3.5.0 |
Description | The newly added Portal Profiles feature introduced the problem. The order of importation causes pf::web::custom to be compiled before pf::web. Making the latter a refused redefinition of the first.
Because of a readily available and simple work-around, we will fix the issue in a clean way: getting rid of Portal::Session's dependency on the pf::web code. To do so there's only one task remaining: killing the last caller on get_client_ip in pf::web and moving that code in Portal::Session. 0001485 describe this de-coupling effort in more details. |
Additional Information | Easy workaround available:
Comment the line 'use pf::web::custom' in lib/pf/Portal/Session.pm
If you customized get_client_ip, you'll need to copy your customization in pf::web since it won't be in effect anymore. |
Tags | No tags attached. |
|
fixed in git revision | 6a7cdad |
fixed in mtn revision | |
|
Attached Files | |
|