PacketFence
Bug Tracking System

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001507PacketFencepublic2012-08-08 10:462012-09-06 10:57
Reporterobilodeau 
Assigned Toobilodeau 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.5.0 
Target Version3.5.1Fixed in Version3.5.1 
Summary0001507: Web extension point (pf::web::custom) no longer works in 3.5.0
DescriptionThe newly added Portal Profiles feature introduced the problem. The order of importation causes pf::web::custom to be compiled before pf::web. Making the latter a refused redefinition of the first.

Because of a readily available and simple work-around, we will fix the issue in a clean way: getting rid of Portal::Session's dependency on the pf::web code. To do so there's only one task remaining: killing the last caller on get_client_ip in pf::web and moving that code in Portal::Session. 0001485 describe this de-coupling effort in more details.
Additional InformationEasy workaround available:

Comment the line 'use pf::web::custom' in lib/pf/Portal/Session.pm

If you customized get_client_ip, you'll need to copy your customization in pf::web since it won't be in effect anymore.
TagsNo tags attached.
fixed in git revision6a7cdad
fixed in mtn revision
Attached Files

- Relationships
related to 0001485resolved pf::web::guest / admin guest creation need some kind of separation 

-  Notes
(0002971)
obilodeau (reporter)
2012-08-27 13:34

work-around applied to stable
(0003018)
obilodeau (reporter)
2012-09-06 10:57

fix released in 3.5.1 yesterday

- Issue History
Date Modified Username Field Change
2012-08-08 10:46 obilodeau New Issue
2012-08-08 10:49 obilodeau Relationship added related to 0001485
2012-08-08 10:50 obilodeau Description Updated
2012-08-08 10:50 obilodeau Additional Information Updated
2012-08-27 11:35 obilodeau Status new => assigned
2012-08-27 11:35 obilodeau Assigned To => obilodeau
2012-08-27 13:34 obilodeau git revision => 6a7cdad
2012-08-27 13:34 obilodeau Note Added: 0002971
2012-08-27 13:34 obilodeau Status assigned => resolved
2012-08-27 13:34 obilodeau Fixed in Version => +1
2012-08-27 13:34 obilodeau Resolution open => fixed
2012-09-06 10:56 obilodeau Target Version +1 => 3.5.1
2012-09-06 10:56 obilodeau Fixed in Version +1 => 3.5.1
2012-09-06 10:57 obilodeau Note Added: 0003018
2012-09-06 10:57 obilodeau Status resolved => closed


Copyright © 2000 - 2012 MantisBT Group
Powered by Mantis Bugtracker