0000512: os.pm and compatibility with Config::IniFiles version 2.45 - PacketFence

(0000982)
user4
2009-01-07 20:38

Reminder sent to: rbalzard

(0000983)
user4
2009-01-07 20:41

--- pf/lib/pf/os.pm 76c24b3e0604ca394a2e32b4f3a0e763163f64e2
+++ pf/lib/pf/os.pm b42265145182b89af69b49faf778603446a9bf2f
@@ -75,9 +75,16 @@ sub read_dhcp_fingerprints_conf {
     my $os_id = $os;
     $os_id =~ s/^os\s+//;
     $os_add_sql->execute($os_id,$dhcp_fingerprints{$os}{"description"});
- foreach my $dhcp_fingerprint (@{$dhcp_fingerprints{$os}{"fingerprints"}}) {
- $fp_total++;
- $dhcp_fingerprint_add_sql->execute($dhcp_fingerprint, $os_id);
+ if (exists($dhcp_fingerprints{$os}{"fingerprints"})) {
+ if (ref($dhcp_fingerprints{$os}{"fingerprints"}) eq "ARRAY") {
+ foreach my $dhcp_fingerprint (@{$dhcp_fingerprints{$os}{"fingerprints"}}) {
+ $fp_total++;
+ $dhcp_fingerprint_add_sql->execute($dhcp_fingerprint, $os_id);
+ }
+ } else {
+ $fp_total++;
+ $dhcp_fingerprint_add_sql->execute($dhcp_fingerprints{$os}{"fingerprints"}, $os_id);
+ }
     }
     foreach my $class (tied(%dhcp_fingerprints)->GroupMembers("class")) {
       my $os_class = $class;

(0000984)
user4
2009-01-07 20:42

fixed in mtn revision bb72f5e79350852ebe8acb6c57f456fbcc20aa24

(0001041)
user4
2009-01-26 12:34

bug exists also at another spot in the code:
./bin/pfcmd config help general.hostname

Can't use string ("Hostname of PacketFence system. ") as an ARRAY ref while "strict refs" in use at ./bin/pfcmd line 849.

(0001042)
user4
2009-01-26 12:35

fixed in mtn revision f4fe0705cb8dc970da0f047744b327361423fa41

Issue History
Date Modified	Username	Field	Change
2009-01-07 20:38	user4	New Issue
2009-01-07 20:38	user4	Status	new => assigned
2009-01-07 20:38	user4	Assigned To	=> user4
2009-01-07 20:38	user4	Note Added: 0000982
2009-01-07 20:41	user4	Note Added: 0000983
2009-01-07 20:42	user4	Status	assigned => closed
2009-01-07 20:42	user4	Note Added: 0000984
2009-01-07 20:42	user4	Resolution	open => fixed
2009-01-26 12:34	user4	Status	closed => feedback
2009-01-26 12:34	user4	Resolution	fixed => reopened
2009-01-26 12:34	user4	Note Added: 0001041
2009-01-26 12:35	user4	Status	feedback => closed
2009-01-26 12:35	user4	Note Added: 0001042
2009-01-26 12:35	user4	Resolution	reopened => fixed
2009-02-12 16:38	user4	Relationship added	related to 0000590
2009-06-10 08:29	user4	Relationship added	related to 0000721
2010-04-15 17:53	obilodeau	Category	1.8.0 => 1.8.x
2012-02-29 10:57	obilodeau	Category	1.8.x => core

Notes
(0000982) user4 2009-01-07 20:38	Reminder sent to: rbalzard

(0000983) user4 2009-01-07 20:41	--- pf/lib/pf/os.pm 76c24b3e0604ca394a2e32b4f3a0e763163f64e2 +++ pf/lib/pf/os.pm b42265145182b89af69b49faf778603446a9bf2f @@ -75,9 +75,16 @@ sub read_dhcp_fingerprints_conf { my $os_id = $os; $os_id =~ s/^os\s+//; $os_add_sql->execute($os_id,$dhcp_fingerprints{$os}{"description"}); - foreach my $dhcp_fingerprint (@{$dhcp_fingerprints{$os}{"fingerprints"}}) { - $fp_total++; - $dhcp_fingerprint_add_sql->execute($dhcp_fingerprint, $os_id); + if (exists($dhcp_fingerprints{$os}{"fingerprints"})) { + if (ref($dhcp_fingerprints{$os}{"fingerprints"}) eq "ARRAY") { + foreach my $dhcp_fingerprint (@{$dhcp_fingerprints{$os}{"fingerprints"}}) { + $fp_total++; + $dhcp_fingerprint_add_sql->execute($dhcp_fingerprint, $os_id); + } + } else { + $fp_total++; + $dhcp_fingerprint_add_sql->execute($dhcp_fingerprints{$os}{"fingerprints"}, $os_id); + } } foreach my $class (tied(%dhcp_fingerprints)->GroupMembers("class")) { my $os_class = $class;

(0000984) user4 2009-01-07 20:42	fixed in mtn revision bb72f5e79350852ebe8acb6c57f456fbcc20aa24

(0001041) user4 2009-01-26 12:34	bug exists also at another spot in the code: ./bin/pfcmd config help general.hostname Can't use string ("Hostname of PacketFence system. ") as an ARRAY ref while "strict refs" in use at ./bin/pfcmd line 849.

(0001042) user4 2009-01-26 12:35	fixed in mtn revision f4fe0705cb8dc970da0f047744b327361423fa41