0000782: redir.cgi crash: Use of uninitialized value in concatenation (.) or string - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000782

PacketFence

public

2009-08-20 14:28

2011-01-26 15:43

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000782: redir.cgi crash: Use of uninitialized value in concatenation (.) or string

Description

Mailing list user reported a problem:

Wed Aug 19 11:05:15 2009] [error] [client 149.xxx.xxx.xxx] [Wed Aug 19 11:05:15 2009] redir.cgi: Use of uninitialized value in concatenation (.) or string at /usr/local/pf/lib/pf/web.pm line 395.

I suggested changing line 395 of lib/pf/web.pm from:
$logger->warn("unknown User-Agent: $user_agent");
to
$logger->warn("unknown User-Agent: ".$user_agent);

and user reported that it fixed his problem.

I should merge that in mtn and evaluate if I mis-used $user_agent somewhere else. Problem most likely occurs when there are quotes or things like that in the $user_agent string.

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Attached Files

Relationships

Notes
(0001339) rbalzard (administrator) 2009-10-15 15:36	I changed $user_agent 2 twice again in web.pm and that was it.

(0001340) rbalzard (administrator) 2009-10-15 15:36	fixed in revision 88bcdd0146de8b604fa21d409103b59d3985f9a1

Issue History
Date Modified	Username	Field	Change
2009-08-20 14:28	obilodeau	New Issue
2009-08-20 14:28	obilodeau	Status	new => assigned
2009-08-20 14:28	obilodeau	Assigned To	=> obilodeau
2009-10-15 15:36	rbalzard	Note Added: 0001339
2009-10-15 15:36	rbalzard	Note Added: 0001340
2009-10-15 15:36	rbalzard	Status	assigned => resolved
2009-10-15 15:36	rbalzard	Resolution	open => fixed
2011-01-26 15:43	obilodeau	Status	resolved => closed