0000796: pfsetvlan doesn't deal with Alarm signals (SIGALRM) - PacketFence - BTS

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0000796

PacketFence

public

2009-09-09 14:55

2011-01-26 15:43

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000796: pfsetvlan doesn't deal with Alarm signals (SIGALRM)

Description

We use so many modules we don't really know or remember if they are thread safe or not. Some of these modules use the alarm() call. According to this perl bug http://rt.perl.org/rt3/Public/Bug/Display.html?id=16807 [^] alarm is not thread-safe.

The way we experienced this is a complete crash of our daemon with no info in the logs. Only a simple die with "Alarm clock" happens.

You can repeat the bug using: kill -s SIGALRM <pfsetvlan pid>

Other links:
http://groups.google.com/group/perl.perl5.porters/browse_frm/thread/99616b4f24bc3e26?hl=en&lr=&ie=UTF-8&oe=UTF-8&rnum=1&prev=/groups%3Fq%3Dperl%2Balarm%2Bclock%2Bthreads%26hl%3Den%26lr%3D%26ie%3DUTF-8%26oe%3DUTF-8%26selm%3Drt-16807-35884.2.54002486802122%2540bugs6.perl.org%26rnum%3D1 [^]

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Relationships

has duplicate	0000907	closed	obilodeau	pfsetvlan doesn't need to stop on SIGALRM
related to	0000902	closed		Net::Telnet and Net::Appliance::Session use alarm() for timeout which is incompatible with threaded perl

Notes
(0001310) obilodeau (reporter) 2009-09-11 16:22	Fixed in mtn: e69d5f5489987e043be147bdaf0489af1b1fcdb4 We can't get who asked for the alarm but at least we don't fail mysteriously without any error message.

Issue History
Date Modified	Username	Field	Change
2009-09-09 14:55	obilodeau	New Issue
2009-09-09 14:55	obilodeau	Status	new => assigned
2009-09-09 14:55	obilodeau	Assigned To	=> obilodeau
2009-09-09 14:57	obilodeau	Status	assigned => confirmed
2009-09-11 16:22	obilodeau	Note Added: 0001310
2009-09-11 16:22	obilodeau	Status	confirmed => resolved
2009-09-11 16:22	obilodeau	Resolution	open => fixed
2010-02-08 13:09	obilodeau	Relationship added	related to 0000902
2010-02-09 10:35	obilodeau	Relationship added	has duplicate 0000907
2011-01-26 15:43	obilodeau	Status	resolved => closed

Copyright © 2000 - 2012 MantisBT Group