0000801: violation add should check for whitelist / trappable IP or MAC / etc. - PacketFence - BTS

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0000801

PacketFence

public

2009-09-15 09:56

2011-01-26 15:43

Reporter

obilodeau

Assigned To

obilodeau

Priority

high

Severity

major

Reproducibility

N/A

Status

closed

Resolution

fixed

Platform

OS

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000801: violation add should check for whitelist / trappable IP or MAC / etc.

Description

Right now, each time we call `pfcmd violation add` we verify before hand if it is whitelisted, trappable or not, etc.

This code is repeated every time and should be placed in the violation class to avoid repeat.

What happened is that right now, vendormac and useragent violations do not do these tests before because I didn't knew about that when I implemented the features.

Heck even an integration test should be done on that.

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Relationships

Notes
(0001314) obilodeau (reporter) 2009-09-25 18:28	increasing severity since this bypass expected behavior on new alarm types

(0001320) obilodeau (reporter) 2009-10-09 11:23	Validation will be done with violation_trigger, when you call pfcmd add (like the web interface does) this doesn't deal with validation. We decided that it is what makes more sense right now.

(0001321) obilodeau (reporter) 2009-10-09 11:35	fix in monotone's rev: cf8fddeefc692d98c4f5d5c381d8c0bfeed532f6 http://mtn.inverse.ca/revision/info/cf8fddeefc692d98c4f5d5c381d8c0bfeed532f6 [^]

Issue History
Date Modified	Username	Field	Change
2009-09-15 09:56	obilodeau	New Issue
2009-09-15 09:56	obilodeau	Status	new => assigned
2009-09-15 09:56	obilodeau	Assigned To	=> obilodeau
2009-09-25 18:28	obilodeau	Note Added: 0001314
2009-09-25 18:28	obilodeau	Priority	normal => high
2009-09-25 18:28	obilodeau	Severity	minor => major
2009-10-09 11:23	obilodeau	Note Added: 0001320
2009-10-09 11:35	obilodeau	Note Added: 0001321
2009-10-09 11:35	obilodeau	Status	assigned => resolved
2009-10-09 11:35	obilodeau	Resolution	open => fixed
2011-01-26 15:43	obilodeau	Status	resolved => closed

Copyright © 2000 - 2012 MantisBT Group