0000936: get rid of use threads where it is not required - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000936

PacketFence

performance

public

2010-03-19 11:58

2015-02-13 15:24

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000936: get rid of use threads where it is not required

Description

Right now, in pf::util we could get rid of them but there are other cases where a bit of moving around will be required. In example pf::vlan.

Everywhere we use threads and threads::shared only to set up:
Log::Log4perl::MDC->put( 'tid', threads->self->tid() );

We should do it at the very beginning of the thread's existence and push that out of modules. In the above vlan example, it should be done in pfsetvlan.

Aside from compile time performance in some spots (pfcmd for instance) another benefit would be that we might be able to use DProf (which currently crashes on our codebase when importing threads).

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Attached Files

Relationships

Notes
(0001699) obilodeau (reporter) 2010-09-28 17:45	this has been partially fixed lately with a removal in pf::vlan

(0003684) lmunro (administrator) 2015-02-13 15:24	These issues are too old to still be relevant. Let's start anew.

Issue History
Date Modified	Username	Field	Change
2010-03-19 11:58	obilodeau	New Issue
2010-03-19 11:58	obilodeau	Status	new => assigned
2010-03-19 11:58	obilodeau	Assigned To	=> obilodeau
2010-04-15 17:43	obilodeau	Project	PacketFence 1.9 => PacketFence
2010-05-04 14:41	obilodeau	Target Version	1.9.0 => 1.10.0
2010-09-28 17:45	obilodeau	Note Added: 0001699
2010-11-19 14:25	obilodeau	Target Version	1.10.0 => 2.0.0
2011-01-18 09:47	obilodeau	Target Version	2.0.0 => 2.1.0
2011-03-03 15:16	obilodeau	Target Version	2.1.0 => +1
2011-03-03 15:18	obilodeau	Target Version	+1 => +2
2015-02-13 15:24	lmunro	Note Added: 0003684
2015-02-13 15:24	lmunro	Status	assigned => closed