0000959: why is there a difference between the parsing threads and the processing threads and does it matter? - PacketFence

Bug Tracking System

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000959

PacketFence

performance

public

2010-04-14 14:55

2015-02-13 15:24

Reporter

obilodeau

Assigned To

obilodeau

Priority

normal

Severity

minor

Reproducibility

N/A

Status

closed

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0000959: why is there a difference between the parsing threads and the processing threads and does it matter?

Description

I ask the question because for the same trap operation we:
in one thread:
- instantiate a switch module
- parse the trap
- lock { put the trap in a traplist }

with another thread:
- lock { wait on a trap to act upon }
- instantiate the same switch module as above
- perform actions

Some problems here: why a difference between a parser (first thread type) and a worker (second thread type) and does it matter? It seems that the re-instantiation and wait-lock would outweigh benefits.

I'll have to investigate the problem of multi-traps that we "intelligently" remove. That's probably the reason of this design.

Some possible ways to improve things:
- instantiating a switch module is a 0.5 sec operation.. And the module is stateless (need to verify) so we might be able to get away with module re-use, ie: once we create it for a specific switch, we re-use it. Especially for the parsing part.

Tags

No tags attached.

fixed in git revision

fixed in mtn revision

Attached Files

Relationships

Notes
(0003670) lmunro (administrator) 2015-02-13 15:24	These issues are too old to still be relevant. Let's start anew.

Issue History
Date Modified	Username	Field	Change
2010-04-14 14:55	obilodeau	New Issue
2010-04-14 14:55	obilodeau	Status	new => assigned
2010-04-14 14:55	obilodeau	Assigned To	=> obilodeau
2010-04-15 17:43	obilodeau	Project	PacketFence 1.9 => PacketFence
2011-01-18 11:41	obilodeau	Target Version	=> 2.1.0
2011-03-03 15:15	obilodeau	Target Version	2.1.0 => +1
2011-03-03 15:18	obilodeau	Target Version	+1 => +2
2015-02-13 15:24	lmunro	Note Added: 0003670
2015-02-13 15:24	lmunro	Status	assigned => closed